-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/v1.3] Use etcd v3.5.3 for Kubernetes 1.22+ #1953
[release/v1.3] Use etcd v3.5.3 for Kubernetes 1.22+ #1953
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@@ -52,7 +52,7 @@ const ( | |||
) | |||
|
|||
// NewConfig returns all required configs to init a cluster via a set of v1beta3 configs | |||
func NewConfig(s *state.State, host kubeoneapi.HostConfig) ([]runtime.Object, error) { | |||
func NewConfig(s *state.State, host kubeoneapi.HostConfig) ([]runtime.Object, error) { //nolint:gocyclo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kron4eg I think it's okay to ignore this lint error because:
- this is a legacy branch
- this has been already fixed in 1.4 and master
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sounds good
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 74008ac6d39edad6c6228f35430ed92144d6a6e4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, kubermatic-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #1951
/assign xmudrii