Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cilium to v1.12.0 #2220

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Update Cilium to v1.12.0 #2220

merged 1 commit into from
Aug 3, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 3, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates Cilium to v1.12.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2219

Does this PR introduce a user-facing change?:

Update Cilium to v1.12.0

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 3, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 3, 2022
addons/cni-cilium/cilium.yaml Show resolved Hide resolved
addons/cni-cilium/cilium.yaml Show resolved Hide resolved
addons/cni-cilium/cilium.yaml Show resolved Hide resolved
addons/cni-cilium/cilium.yaml Show resolved Hide resolved
@@ -176,13 +200,59 @@ data:
cluster-pool-ipv4-cidr: "{{.Config.ClusterNetwork.PodSubnet }}"
cluster-pool-ipv4-mask-size: "24"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: This is maybe not correct.

Copy link
Contributor

@rastislavs rastislavs Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{.Config.ClusterNetwork.PodSubnet }} looks good to me here.
Going forward it may be helpful to make mask-size configurable as well, but if it was not demanded up til now, the default should be fine.

addons/cni-cilium/cilium.yaml Show resolved Hide resolved
addons/cni-cilium/cilium.yaml Show resolved Hide resolved
@xmudrii
Copy link
Member Author

xmudrii commented Aug 3, 2022

/test pull-kubeone-e2e-aws-defaults-cilium-containerd-v1.22.11

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Aug 3, 2022

/test pull-kubeone-e2e-aws-defaults-cilium-containerd-v1.22.11

@xmudrii
Copy link
Member Author

xmudrii commented Aug 3, 2022

Some conformance tests are failing, but that's as expected (see cilium/cilium#14287 and cilium/cilium#12116).

    helpers.go:523: some e2e tests failed:
        [
          {
            "name": "[sig-network] HostPort validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance]",
            "status": "failed",
            "details": {}
          },
          {
            "name": "[sig-network] Services should have session affinity work for service with type clusterIP [LinuxOnly] [Conformance]",
            "status": "failed",
            "details": {}
          }
        ]

/override pull-kubeone-e2e-aws-defaults-cilium-containerd-v1.22.11

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-defaults-cilium-containerd-v1.22.11

In response to this:

Some conformance tests are failing, but that's as expected (see cilium/cilium#14287 and cilium/cilium#12116).

   helpers.go:523: some e2e tests failed:
       [
         {
           "name": "[sig-network] HostPort validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance]",
           "status": "failed",
           "details": {}
         },
         {
           "name": "[sig-network] Services should have session affinity work for service with type clusterIP [LinuxOnly] [Conformance]",
           "status": "failed",
           "details": {}
         }
       ]

/override pull-kubeone-e2e-aws-defaults-cilium-containerd-v1.22.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii marked this pull request as ready for review August 3, 2022 11:43
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@xmudrii xmudrii requested a review from kron4eg August 3, 2022 11:43
@kron4eg
Copy link
Member

kron4eg commented Aug 3, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 879ced545b661ab8f9008adc934832082440390e

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@xmudrii xmudrii added this to the KubeOne 1.5 milestone Aug 3, 2022
@kubermatic-bot kubermatic-bot merged commit 07fd385 into master Aug 3, 2022
@kubermatic-bot kubermatic-bot deleted the cilium-1.12 branch August 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump cilium to version 1.12
5 participants