Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to cilium v1.12.2 #2359

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Upgrade to cilium v1.12.2 #2359

merged 1 commit into from
Sep 22, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Sep 22, 2022 •
edited by xmudrii
Loading

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What this PR does / why we need it:

Upgrade to cilium v1.12.2.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

This is a pre-requisite for #2223

Does this PR introduce a user-facing change? Then add your Release Note here:

Upgrade Cilium from v1.12.0 to v1.12.2

Documentation:

NONE

@ahmedwaleedmalik
Upgrade to cilium v1.12.2
028fa97 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Sep 22, 2022
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-e2e-aws-default-cilium-containerd-v1.22.12

@ahmedwaleedmalik
Copy link
Member Author

Something seems broken, I'll try to reproduce this locally.

xmudrii
xmudrii approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 414f89de1855687a2f8718f63a5b5bce13b8284c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@xmudrii
Copy link
Member

xmudrii commented Sep 22, 2022

@ahmedwaleedmalik It's expected that the Cilium job fails. Some conformance tests are failing, but that's a known issue in Cilium. See the following tickets for more details:

We can't do much about that besides eventually skipping those tests.

That said...
/override pull-kubeone-e2e-aws-default-cilium-containerd-v1.22.12

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-default-cilium-containerd-v1.22.12

In response to this:

@ahmedwaleedmalik It's expected that the Cilium job fails. Some conformance tests are failing, but that's a known issue in Cilium. See the following tickets for more details:

We can't do much about that besides eventually skipping those tests.

That said...
/override pull-kubeone-e2e-aws-default-cilium-containerd-v1.22.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Sep 22, 2022 •
edited
Loading

@ahmedwaleedmalik I'll put the PR on hold, but feel free to remove the hold if the PR is ready to be merged.
/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2022
@Waseem826
Copy link
Contributor

Waseem826 commented Sep 22, 2022 •
edited
Loading

/unhold

On behalf of @ahmedwaleedmalik

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2022
@kubermatic-bot kubermatic-bot merged commit 870c3ec into kubermatic:master Sep 22, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.6 milestone Sep 22, 2022
@xmudrii
Copy link
Member

xmudrii commented Sep 26, 2022

/cherrypick release/v1.5

@kubermatic-bot kubermatic-bot mentioned this pull request Sep 26, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2376

In response to this:

/cherrypick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik ahmedwaleedmalik deleted the cilium-12.2 branch September 26, 2022 07:47
@kubermatic-bot kubermatic-bot added the docs/none Denotes a PR that doesn't need documentation (changes). label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmedwaleedmalik @kubermatic-bot @xmudrii @Waseem826