New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logging to label step #3070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: cfd168bf4fc4eca109d0e07d416935bdc770e4da
|
/retest Review the full test history Silence the bot with an |
/hold @SimonTheLeg please rebase the PR as we've got changes in prow config and now failing job is not there anymore 🤷 |
/skip |
@kron4eg Shouldn't be needed to rebase |
/skip |
¯_(ツ)_/¯ |
@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-default-install-containerd-v1.25.15 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
682fe20
to
0494fa1
Compare
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
LGTM label has been added. Git tree hash: 64b5e914df507d44624552b1ad3720b906f80622
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@SimonTheLeg: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Review the full test history Silence the bot with an |
What this PR does / why we need it:
Adds a logging line to indicate that kubeone is starting to label nodes. Without this line I felt that error messages can sometimes be confusing. Here is an example, where label nodes failed:
My first impression was that applying the nodelocaldns addon failed (which was not the case), because there is no mention of label nodes.
What type of PR is this?
/kind cleanup
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: