Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to Go 1.22.1 #3072

Merged
merged 1 commit into from
Mar 6, 2024
Merged

update to Go 1.22.1 #3072

merged 1 commit into from
Mar 6, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 6, 2024

What this PR does / why we need it:
This bumps KKP to Go 1.22.1, which comes with some important fixes: https://groups.google.com/g/golang-announce/c/Fm51GRLNRvM/m/F5bwBlXMAQAJ

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Update to Go 1.22.1

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 6, 2024
@xrstf xrstf requested a review from kron4eg March 6, 2024 12:29
@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 6, 2024
@kron4eg
Copy link
Member

kron4eg commented Mar 6, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 617438525b42f822d9fafdf94e6fa05a80ad204c

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@xrstf
Copy link
Contributor Author

xrstf commented Mar 6, 2024

@kron4eg The postsubmits for kubeone are included in the aggregated PR https://github.com/kubermatic/infra/pull/2601, I hope it's okay for KubeOne to be temporarily out of sync.

@kron4eg
Copy link
Member

kron4eg commented Mar 6, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit 5014d9d into kubermatic:main Mar 6, 2024
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Mar 6, 2024
@xrstf xrstf deleted the go1221 branch March 6, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @kron4eg @kubermatic-bot