Cross deletion of cluster tags in vSphere

[ahmedwaleedmalik]

What happened?

Currently, the logic to clean up "tags" for clusters is the following:

• While reconciling a cluster check if tags exist
• If they exist, fetch all tags against the tag category
• Skip tags configured for that cluster and delete all the other tags that are not associated with any entity(other vSphere resources)

This is highly problematic as we end up removing tags that are completely unrelated to this cluster. There should be no interference with unrelated/unlinked tags whatsoever.

How to reproduce the issue?

Create two clusters with tags A, B, and C,D, respectively against the same tag category. Don't assign those tags to machines or any other resources. C,D will be removed when first cluster is reconciled and A,B when the second cluster is reconciled.

How is your environment configured?

• KKP version: 2.23
• Shared or separate master/seed clusters?:

Additional information

The solution needs to be backported as well.

[ahmedwaleedmalik]

/assign @ahmedwaleedmalik

[ahmedwaleedmalik]

/milestone KKP 2.26

[kubermatic-bot]

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[steled]

/remove-lifecycle stale

[csengerszabo]

/milestone clear