Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the default number of replicas for controlplane components #3885

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

alvaroaleman
Copy link
Contributor

What this PR does / why we need it:

Allows setting the default number of replicas for controlplane components. Defaults the number of apiserver replicas to two, as requested by the sebastian.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

[BREAKING] The default number of apiserver replicas was increased to 2. You can revert to the old behavior by setting `.Kubermatic.apiserverDefaultReplicas` in the `values.yaml`

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. team/lifecycle size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2019
@alvaroaleman
Copy link
Contributor Author

/assign @nikhita

Copy link
Contributor

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Lgtm on the what the PR does, but out of curiosity:

Defaults the number of apiserver replicas to two, as requested by the sebastian.

Why are we doing this?

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aa85d3f6ca971a419479a12eb7adbca22ba9d3fa

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@nikhita
Copy link
Contributor

nikhita commented Jul 25, 2019

Ooops requires rebase 🤦‍♀️

@alvaroaleman
Copy link
Contributor Author

Why are we doing this?

Because that makes the api much more ha. For the controllers it doesn't matter as much, as they are not doing anything without the leader lock anyways

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@nikhita
Copy link
Contributor

nikhita commented Jul 25, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 13ee1902702bcb1e07e359c12cfa706deae64731

@alvaroaleman
Copy link
Contributor Author

Also, a downtime of the API is something ppl notice instantly as kubectl doesn't work anymore, downtime of the controller-manager or scheduler just results in parts of the reconciling not happening instantly anymore

@kubermatic-bot kubermatic-bot merged commit 5ceb3b7 into master Jul 25, 2019
@kubermatic-bot kubermatic-bot deleted the default-component-override branch July 25, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants