-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the default number of replicas for controlplane components #3885
Conversation
8bfe588
to
81e07ce
Compare
/assign @nikhita |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Lgtm on the what the PR does, but out of curiosity:
Defaults the number of apiserver replicas to two, as requested by the sebastian.
Why are we doing this?
LGTM label has been added. Git tree hash: aa85d3f6ca971a419479a12eb7adbca22ba9d3fa
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ooops requires rebase 🤦♀️ |
Because that makes the api much more ha. For the controllers it doesn't matter as much, as they are not doing anything without the leader lock anyways |
81e07ce
to
f08fa54
Compare
/lgtm |
LGTM label has been added. Git tree hash: 13ee1902702bcb1e07e359c12cfa706deae64731
|
Also, a downtime of the API is something ppl notice instantly as |
What this PR does / why we need it:
Allows setting the default number of replicas for controlplane components. Defaults the number of apiserver replicas to two, as requested by the sebastian.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: