Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make worker-count of controller-manager and master-controller configurable #3918

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

bashofmann
Copy link
Contributor

What this PR does / why we need it:
Make worker-count of controller-manager and master-controller configurable in helm chart

A higher worker count can speed up the controllers, especially the rbac controller significantly in larger installations

Does this PR introduce a user-facing change?:

The worker-count of controller-manager and master-controller are now configurable

…rable in helm chart

A higher worker count can speed up the controllers, especially the rbac controller significantly in larger installations
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 31, 2019
@kubermatic-bot
Copy link
Contributor

Hi @bashofmann. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2019
@alvaroaleman
Copy link
Contributor

/lgtm
/approve
CC @floreks @xrstf

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f259b309693ff9c35507fffc188014ac1d89a2e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@kubermatic-bot kubermatic-bot merged commit fa230f2 into master Jul 31, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Jul 31, 2019
@kubermatic-bot kubermatic-bot deleted the feature/configurable-worker-count branch July 31, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants