Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: remove the remains of hardcoded AZ from datacenter and cluster configuration #3986

Merged
merged 1 commit into from
Aug 8, 2019
Merged

AWS: remove the remains of hardcoded AZ from datacenter and cluster configuration #3986

merged 1 commit into from
Aug 8, 2019

Conversation

kdomanski
Copy link
Contributor

@kdomanski kdomanski commented Aug 7, 2019 •
edited
Loading

What this PR does / why we need it:
It removes useless code and data field related to how AWS clusters behaved before we had multiple AZ support.

ACTION REQUIRED: the `zone_character` field must be removed from all AWS datacenters in `datacenters.yaml`

@kubermatic-bot kubermatic-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. team/lifecycle size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 7, 2019
@kdomanski
Copy link
Contributor Author

/retest

@kdomanski
Copy link
Contributor Author

/retest

@kdomanski
Copy link
Contributor Author

/assign @alvaroaleman

alvaroaleman
alvaroaleman reviewed Aug 8, 2019
View reviewed changes
api/pkg/crd/kubermatic/v1/cluster.go
@@ -316,8 +316,6 @@ type AWSCloudSpec struct {
RouteTableID string `json:"routeTableId"`
InstanceProfileName string `json:"instanceProfileName"`
SecurityGroupID string `json:"securityGroupID"`

AvailabilityZone string `json:"availabilityZone"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to pre-existing AWS clusters? If someone updates an existing NodeDeployment in an existing AWS cluster, will everything stay the same except for the given update? What about a new NodeDeployment, are additional settings required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing NodeDeployments should not be affected, since the AZ from the cluster used to get simply copied into the MD object. New NodeDeployments have their AZ assigned by the UI.

@alvaroaleman
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26510adb0fe7d38baf0f0b8b94f26f7a8fdd1d72

@kdomanski
Copy link
Contributor Author

/assign @zreigz

@zreigz
Copy link
Contributor

zreigz commented Aug 8, 2019

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2019
@kubermatic-bot kubermatic-bot merged commit 81001eb into master Aug 8, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Aug 8, 2019
@kubermatic-bot kubermatic-bot deleted the remove-hardcoded-az branch August 8, 2019 11:53
@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 8, 2019
@alvaroaleman alvaroaleman mentioned this pull request Aug 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman left review comments

Assignees

@zreigz zreigz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdomanski @alvaroaleman @kubermatic-bot @zreigz