Implement different roles for worker nodes & the control plane #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
/retest |
|
/assign @alvaroaleman |
alvaroaleman
reviewed
Aug 8, 2019
mrIncompetent
force-pushed
the
aws-policies
branch
from
6e2566b
to
43ba204
Compare
alvaroaleman
reviewed
Aug 9, 2019
api/pkg/crd/kubermatic/v1/cluster.go
Outdated
| RouteTableID string `json:"routeTableId"` | ||
| InstanceProfileName string `json:"instanceProfileName"` | ||
| SecurityGroupID string `json:"securityGroupID"` | ||
|
|
||
| AvailabilityZone string `json:"availabilityZone"` |
There was a problem hiding this comment.
Why did you re-add this? @kdomanski deliberately remvoved it in #3986
There was a problem hiding this comment.
I screwed up the merge 🤦♂️
There was a problem hiding this comment.
Gone with 564566e
|
/lgtm |
|
LGTM label has been added. Git tree hash: cf8160ccd84596054de1f21ffbe9c032a3034c7c
|
|
/assign @zreigz |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, zreigz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will make sure that we:
I decided against creating new API credentials as that would not make any improvement, since the control plane does a assume-role.
Fixes #3716
Does this PR introduce a user-facing change?: