Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluentBit: Always set the node name in logs #4010

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

mrIncompetent
Copy link
Contributor

What this PR does / why we need it:
This change ensures that we always set the node name on logs.
This is especially useful if we collect logs from multiple sources (kmesg, journald).

Does this PR introduce a user-facing change?:

FluentBit now always sets the node name in logs

@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 8, 2019
@mrIncompetent
Copy link
Contributor Author

/assign @xrstf

@kubermatic-bot kubermatic-bot added team/seed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2019
@xrstf
Copy link
Contributor

xrstf commented Aug 8, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c9618f0d1d134f387f312a727f317eeb9b8bd3c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2019
@kubermatic-bot kubermatic-bot merged commit bff86e5 into master Aug 8, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Aug 8, 2019
@kubermatic-bot kubermatic-bot deleted the fluentbit-node-name branch August 8, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants