Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share cluster: Set up oidc groups-claim #4244

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Conversation

alvaroaleman
Copy link
Contributor

What this PR does / why we need it:

Sets the oidc groups claim when the share cluster feature is enabled, so groups can be used for permission management.

I've tested that this does't cause issues when the IDP does not set the groups property

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

The share cluster feature now allows to use groups, if passed by the IDP. All groups are prefixed with `oidc:`

/assign @thz @zreigz

@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 3, 2019
@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2019
@thz
Copy link
Contributor

thz commented Sep 3, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a3de3c5acbfdf76022ee8369bab1c41e02c2361

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@kubermatic-bot kubermatic-bot merged commit e12d186 into master Sep 3, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Sep 3, 2019
@kubermatic-bot kubermatic-bot deleted the oidc-group branch September 3, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants