Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to auto update nodes #4258

Merged
merged 14 commits into from
Sep 6, 2019
Merged

Add option to auto update nodes #4258

merged 14 commits into from
Sep 6, 2019

Conversation

alvaroaleman
Copy link
Contributor

@alvaroaleman alvaroaleman commented Sep 5, 2019 •
edited
Loading

What this PR does / why we need it:

Adds the option to configure automaticNodeUpdate in the updates file which will then automatically update the nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4257

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

It is now possible to also configure automatic node updates by setting `automaticNodeUpdate: true` in the `updates.yaml`. This option implies `automatic: true` as node versions must not be newer than the version of the corresponding controlplane.

/hold
Until I have tried out if this actually works
/assign @thz

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. team/lifecycle size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 5, 2019
@thz
Copy link
Contributor

thz commented Sep 5, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 005685062fa935be174e2068efec586f3a0df4c6

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@alvaroaleman
Copy link
Contributor Author

/retest

@alvaroaleman
Copy link
Contributor Author

/assign @xrstf

@alvaroaleman
Copy link
Contributor Author

/approve

xrstf
xrstf reviewed Sep 6, 2019
View reviewed changes
api/pkg/version/manager_test.go Outdated
expectedVersion: &Version{Version: semver.MustParse("1.6.0")},
},
{
name: "Node compatibity check fails, error",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xrstf Would you mind extending the existing lint presubmit/adding a new one that checks spelling?

xrstf
xrstf reviewed Sep 6, 2019
View reviewed changes
api/pkg/version/manager.go Outdated Show resolved Hide resolved
@xrstf
Copy link
Contributor

xrstf commented Sep 6, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4ffdd7f9f53dd6f10f4d0fc4e63bf6acba48543d

@alvaroaleman
Copy link
Contributor Author

/assign @zreigz

@zreigz
Copy link
Contributor

zreigz commented Sep 6, 2019

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@alvaroaleman
Copy link
Contributor Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2019
@kubermatic-bot kubermatic-bot merged commit 0000b49 into master Sep 6, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Sep 6, 2019
@kubermatic-bot kubermatic-bot deleted the node-auto-update branch September 6, 2019 09:36
@alvaroaleman alvaroaleman mentioned this pull request Sep 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf left review comments

Assignees

@xrstf xrstf

@zreigz zreigz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alvaroaleman @thz @kubermatic-bot @xrstf @zreigz