Allow disabling of apiserver endpoints reconciler #4396
Conversation
This change introduces .apiserver.endpointReconcilingDisabled in componentsOverride of the Cluster CR. When enabled the apiserver is started with --endpoint-reconciler-type=none which disables the reconciling of the apiserver endpoint (default: false). This change also introduces the flag --apiserver-endpoint-reconciling-disabled for kubermatic-controller-manager which lets the clusterComponentDefaulter controller default .endpointReconcilingDisabled to true for all Clusters.
kubermatic-bot
added
release-note
|
/hold |
kubermatic-bot
added
the
do-not-merge/hold
api/pkg/crd/kubermatic/v1/cluster.go
Outdated
| ControllerManager DeploymentSettings `json:"controllerManager"` | ||
| Scheduler DeploymentSettings `json:"scheduler"` | ||
| Etcd StatefulSetSettings `json:"etcd"` | ||
| Prometheus StatefulSetSettings `json:"prometheus"` | ||
| } | ||
|
|
||
| type APIServerSettings struct { | ||
| DeploymentSettings |
There was a problem hiding this comment.
This needs a json:",inline" tag
|
/lgtm |
|
LGTM label has been added. Git tree hash: f8e22a118653a81a9e3cb57e9c3839396e099689
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, thz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@thz please also describe the use case and the functionality in the documentation. i think it's not so easy for end user to see for what this flag can be used |
This change introduces .apiserver.endpointReconcilingDisabled in
componentsOverride of the Cluster CR. When enabled the apiserver
is started with --endpoint-reconciler-type=none which disables
the reconciling of the apiserver endpoint (default: false).
This change also introduces the flag --apiserver-endpoint-reconciling-disabled
for kubermatic-controller-manager which lets the
clusterComponentDefaulter controller default .endpointReconcilingDisabled
to true for all Clusters.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: