Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix componentsOverride affecting default values when reconciling clusters #5702

Merged

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jul 22, 2020

What this PR does / why we need it:
resources.SetResourceRequirements() accidentally modified the given default requirements, which lead to more or less random effects on other clusters, depending on the reconciling order.

This seems to have been introduced in December 2019 via #4810, so 2.13+ version are affected.

Which issue(s) this PR fixes:
Fixes #5654

Does this PR introduce a user-facing change?:

Fix componentsOverride of a cluster affecting other clusters.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@xrstf xrstf force-pushed the fix-components-override-spilling branch from 4662fd7 to b2ac9ba Compare July 23, 2020 00:40
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2020
@xrstf
Copy link
Contributor Author

xrstf commented Jul 23, 2020

/retest

@irozzo-1A
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 74c8a173f151e21b728c49c8b7d3cdf5bff3994e

@kubermatic-bot kubermatic-bot merged commit 5eb25b2 into kubermatic:master Jul 23, 2020
@kubermatic-bot kubermatic-bot added this to the v2.15 milestone Jul 23, 2020
@xrstf xrstf deleted the fix-components-override-spilling branch July 23, 2020 07:32
@xrstf
Copy link
Contributor Author

xrstf commented Jul 23, 2020

/cherry-pick release/v2.13

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #5703

In response to this:

/cherry-pick release/v2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor Author

xrstf commented Jul 23, 2020

/cherry-pick release/v2.14

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #5704

In response to this:

/cherry-pick release/v2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

componentsOverride settings spill into other clusters
3 participants