-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix componentsOverride affecting default values when reconciling clusters #5702
fix componentsOverride affecting default values when reconciling clusters #5702
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4662fd7
to
b2ac9ba
Compare
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 74c8a173f151e21b728c49c8b7d3cdf5bff3994e
|
/cherry-pick release/v2.13 |
@xrstf: new pull request created: #5703 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v2.14 |
@xrstf: new pull request created: #5704 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
resources.SetResourceRequirements()
accidentally modified the given default requirements, which lead to more or less random effects on other clusters, depending on the reconciling order.This seems to have been introduced in December 2019 via #4810, so 2.13+ version are affected.
Which issue(s) this PR fixes:
Fixes #5654
Does this PR introduce a user-facing change?: