-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Prometheus alerts using oldstyle label selector #6167
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release/v2.15 |
@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 67bd100a853e9b00f2a06ed9f9cfb49340cc198e
|
b2f6bea
to
6dd6509
Compare
/lgtm |
LGTM label has been added. Git tree hash: 596f3951d5e3aa6a096e798bb9f74c04ea7bc974
|
/retest |
@xrstf: #6167 failed to apply on top of branch "release/v2.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
When moving to the operator, we also switched around the labels. This made the Prometheus alerts misfire. To keep the newly fixed rules compatible with the old Helm chart, I adjusted the chart to also provide the new labels.
Fixes #6152.
Does this PR introduce a user-facing change?: