Add endpoint for OIDC kubeconfig secret for WEB terminal #10102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
zreigz
force-pushed
the
create-oidc-kubeconfig-secret
branch
from
4b5cffd
to
e8c728f
Compare
kubermatic-bot
added
size/XXL
zreigz
force-pushed
the
create-oidc-kubeconfig-secret
branch
3 times, most recently
from
d186648
to
ef9775f
Compare
zreigz
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
zreigz
force-pushed
the
create-oidc-kubeconfig-secret
branch
from
ef9775f
to
116d090
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
zreigz
force-pushed
the
create-oidc-kubeconfig-secret
branch
from
116d090
to
488a1e8
Compare
|
/retest |
|
LGTM label has been added. Git tree hash: c89090fbbd4ad11df705984ebf90d41b9ea2d55a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, zreigz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
KhizerRehan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / Why do we need it: add an endpoint for OIDC kubeconfig secret for the WEB terminal.
Does this PR close any issues?:
Fixes #
Special notes for your reviewer:
In order to test this locally:
kubermaticIssuerclient) to whitelist theredirectURI:http://localhost:8080/api/v2/kubeconfig/secretandhttps://kubermatic.io/api/v2/kubeconfig/secretkubectl -n oauth edit configmap dexkubectl -n oauth rollout restart deployment dexmake clean && FEATURE_GATES=OIDCKubeCfgEndpoint=true KUBERMATIC_EDITION=ee KUBERMATIC_DEBUG=false ./hack/run-api.shOpen WEB browser and enter:
http://localhost:8080/api/v2/kubeconfig/secret?cluster_id=<clusterID>&project_id=<projectID>&user_id=<userID>. Make sure to replaceclusterID,userIDandprojectIDwith the values of the created cluster. The userID is the ID for the user object in the KKP.kube-systemnamespace. The secret name is your email encoded to md5 hash. You can check the name here https://www.md5hashgenerator.com/. For example for userlukasz.zajaczkowski@kubermatic.comwe will get40ce6d00769edaab4eb1d8cacfea5cb1