Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move image-loader functionality to installer subcommand mirror-images #10129

Merged
merged 13 commits into from Jun 22, 2022
Merged

Move image-loader functionality to installer subcommand mirror-images #10129

merged 13 commits into from Jun 22, 2022

Conversation

embik
Copy link
Member

@embik embik commented Jun 20, 2022 •
edited

What does this PR do / Why do we need it:

The image-loader utility does not support EE images because it's built for CE only. This PR removes it as a standalone tool and instead provides a command called mirror-images for kubermatic-installer.

Does this PR close any issues?:
Fixes #9921

Special notes for your reviewer:

Documentation:

kubermatic/docs#1090

Does this PR introduce a user-facing change?:

- The `image-loader` utility has been removed and its functionality is available via the installer's `mirror-images` subcommand instead
- A `--docker-binary` flag has been added to `kubermatic-installer mirror-images` to specify a custom docker binary

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jun 20, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 20, 2022
@embik
Copy image-loader logic to pkg/install/images
5ca0650 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Add kubermatic-installer subcommand mirror-images that will replace…
eb9855e 
… `image-loader`

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Unify command description to produce consistent help output
3cc2382 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Port image-loader logic to kkp-installer mirror-images
6eef311 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Remove image-loader, move docker pkg into pkg/install/images
dd8fe47 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Minor adjustments
6fb28c5 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik force-pushed the kkp-installer-mirror-images branch from 70c6fc5 to 6fb28c5 Compare June 21, 2022 08:45
@embik
Default loaded KubermaticConfiguration and add Azure + VMware Cloud D…
f17d8e0 
…irector images

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Set external cloud provider for Anexia and enable kubernetes-dashboard
8990583 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Make output pretty and support a --docker-binary flag
2927386 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik marked this pull request as ready for review June 21, 2022 12:59
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2022
@embik
Copy link
Member Author

embik commented Jun 21, 2022

Current example output:

./_build/kubermatic-installer --charts-directory charts/ mirror-images --config ~/Workspace/deployments/kkp-2.20/kubermatic.yaml --addons-path ./addons test.embik.me --docker-binary podman --dry-run
INFO[14:59:35] 🚀 Collecting images…
INFO[14:59:47] 🚀 Rendering Helm charts…                      charts-directory=charts/
INFO[14:59:52] Image found                                   source-image="anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1" target-image="test.embik.me/anexia/anx-cloud-controller-manager:1.4.1"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/cni:v3.19.1" target-image="test.embik.me/calico/cni:v3.19.1"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/cni:v3.20.2" target-image="test.embik.me/calico/cni:v3.20.2"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/cni:v3.21.2" target-image="test.embik.me/calico/cni:v3.21.2"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/cni:v3.22.1" target-image="test.embik.me/calico/cni:v3.22.1"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/cni:v3.8.0" target-image="test.embik.me/calico/cni:v3.8.0"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/kube-controllers:v3.19.1" target-image="test.embik.me/calico/kube-controllers:v3.19.1"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/kube-controllers:v3.20.2" target-image="test.embik.me/calico/kube-controllers:v3.20.2"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/kube-controllers:v3.21.2" target-image="test.embik.me/calico/kube-controllers:v3.21.2"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/kube-controllers:v3.22.1" target-image="test.embik.me/calico/kube-controllers:v3.22.1"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/node:v3.19.1" target-image="test.embik.me/calico/node:v3.19.1"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/node:v3.20.2" target-image="test.embik.me/calico/node:v3.20.2"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/node:v3.21.2" target-image="test.embik.me/calico/node:v3.21.2"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/node:v3.22.1" target-image="test.embik.me/calico/node:v3.22.1"
INFO[14:59:52] Image found                                   source-image="docker.io/calico/node:v3.8.0" target-image="test.embik.me/calico/node:v3.8.0"
INFO[14:59:52] Image found                                   source-image="docker.io/envoyproxy/envoy-alpine:v1.17.1" target-image="test.embik.me/envoyproxy/envoy-alpine:v1.17.1"
INFO[14:59:52] Image found                                   source-image="docker.io/envoyproxy/envoy:v1.18.4@sha256:e5c2bb2870d0e59ce917a5100311813b4ede96ce4eb0c6bfa879e3fbe3e83935" target-image="test.embik.me/envoyproxy/envoy:v1.18.4"
INFO[14:59:52] Image found                                   source-image="docker.io/grafana/grafana:8.1.2" target-image="test.embik.me/grafana/grafana:8.1.2"
INFO[14:59:52] Image found                                   source-image="docker.io/grafana/loki:2.5.0" target-image="test.embik.me/grafana/loki:2.5.0"
INFO[14:59:52] Image found                                   source-image="docker.io/grafana/promtail:2.5.0" target-image="test.embik.me/grafana/promtail:2.5.0"
INFO[14:59:52] Image found                                   source-image="docker.io/hetznercloud/hcloud-cloud-controller-manager:v1.12.1" target-image="test.embik.me/hetznercloud/hcloud-cloud-controller-manager:v1.12.1"
INFO[14:59:52] Image found                                   source-image="docker.io/hetznercloud/hcloud-csi-driver:1.6.0" target-image="test.embik.me/hetznercloud/hcloud-csi-driver:1.6.0"
INFO[14:59:52] Image found                                   source-image="docker.io/jimmidyson/configmap-reload:v0.7.1" target-image="test.embik.me/jimmidyson/configmap-reload:v0.7.1"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/cinder-csi-plugin:v1.21.0" target-image="test.embik.me/k8scloudprovider/cinder-csi-plugin:v1.21.0"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/cinder-csi-plugin:v1.22.0" target-image="test.embik.me/k8scloudprovider/cinder-csi-plugin:v1.22.0"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/cinder-csi-plugin:v1.23.0" target-image="test.embik.me/k8scloudprovider/cinder-csi-plugin:v1.23.0"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/cinder-csi-plugin:v1.24.0" target-image="test.embik.me/k8scloudprovider/cinder-csi-plugin:v1.24.0"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/openstack-cloud-controller-manager:v1.21.0" target-image="test.embik.me/k8scloudprovider/openstack-cloud-controller-manager:v1.21.0"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/openstack-cloud-controller-manager:v1.22.0" target-image="test.embik.me/k8scloudprovider/openstack-cloud-controller-manager:v1.22.0"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/openstack-cloud-controller-manager:v1.23.1" target-image="test.embik.me/k8scloudprovider/openstack-cloud-controller-manager:v1.23.1"
INFO[14:59:52] Image found                                   source-image="docker.io/k8scloudprovider/openstack-cloud-controller-manager:v1.24.0" target-image="test.embik.me/k8scloudprovider/openstack-cloud-controller-manager:v1.24.0"
INFO[14:59:52] Image found                                   source-image="docker.io/kubernetesui/dashboard:v2.4.0" target-image="test.embik.me/kubernetesui/dashboard:v2.4.0"
INFO[14:59:52] Image found                                   source-image="docker.io/kubernetesui/dashboard:v2.5.1" target-image="test.embik.me/kubernetesui/dashboard:v2.5.1"
INFO[14:59:52] Image found                                   source-image="docker.io/kubernetesui/dashboard:v2.6.0" target-image="test.embik.me/kubernetesui/dashboard:v2.6.0"
INFO[14:59:52] Image found                                   source-image="docker.io/kumina/openvpn-exporter:v0.2.2" target-image="test.embik.me/kumina/openvpn-exporter:v0.2.2"
INFO[14:59:52] Image found                                   source-image="docker.io/library/busybox:1.33" target-image="test.embik.me/library/busybox:1.33"
INFO[14:59:52] Image found                                   source-image="docker.io/lmierzwa/karma:v0.103" target-image="test.embik.me/lmierzwa/karma:v0.103"
INFO[14:59:52] Image found                                   source-image="docker.io/minio/minio:RELEASE.2022-02-16T00-35-27Z" target-image="test.embik.me/minio/minio:RELEASE.2022-02-16T00-35-27Z"
INFO[14:59:52] Image found                                   source-image="docker.io/nginxinc/nginx-unprivileged:1.20.1-alpine" target-image="test.embik.me/nginxinc/nginx-unprivileged:1.20.1-alpine"
INFO[14:59:52] Image found                                   source-image="docker.io/sstarcher/helm-exporter:1.2.2" target-image="test.embik.me/sstarcher/helm-exporter:1.2.2"
INFO[14:59:52] Image found                                   source-image="docker.io/velero/velero:v1.8.1" target-image="test.embik.me/velero/velero:v1.8.1"
INFO[14:59:52] Image found                                   source-image="gcr.io/cloud-provider-vsphere/cpi/release/manager:v1.21.3" target-image="test.embik.me/cloud-provider-vsphere/cpi/release/manager:v1.21.3"
INFO[14:59:52] Image found                                   source-image="gcr.io/cloud-provider-vsphere/cpi/release/manager:v1.22.6" target-image="test.embik.me/cloud-provider-vsphere/cpi/release/manager:v1.22.6"
INFO[14:59:52] Image found                                   source-image="gcr.io/cloud-provider-vsphere/cpi/release/manager:v1.23.0" target-image="test.embik.me/cloud-provider-vsphere/cpi/release/manager:v1.23.0"
INFO[14:59:52] Image found                                   source-image="gcr.io/cloud-provider-vsphere/csi/release/driver:v2.5.1" target-image="test.embik.me/cloud-provider-vsphere/csi/release/driver:v2.5.1"
INFO[14:59:52] Image found                                   source-image="gcr.io/cloud-provider-vsphere/csi/release/syncer:v2.5.1" target-image="test.embik.me/cloud-provider-vsphere/csi/release/syncer:v2.5.1"
INFO[14:59:52] Image found                                   source-image="gcr.io/etcd-development/etcd:v3.4.3" target-image="test.embik.me/etcd-development/etcd:v3.4.3"
INFO[14:59:52] Image found                                   source-image="gcr.io/etcd-development/etcd:v3.5.4" target-image="test.embik.me/etcd-development/etcd:v3.5.4"
INFO[14:59:52] Image found                                   source-image="gcr.io/google_containers/heapster-amd64:v1.5.2" target-image="test.embik.me/google_containers/heapster-amd64:v1.5.2"
INFO[14:59:52] Image found                                   source-image="ghcr.io/dexidp/dex:v2.32.0" target-image="test.embik.me/dexidp/dex:v2.32.0"
INFO[14:59:52] Image found                                   source-image="ghcr.io/k8snetworkplumbingwg/multus-cni:v3.8.1" target-image="test.embik.me/k8snetworkplumbingwg/multus-cni:v3.8.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/addon-resizer:1.8.14" target-image="test.embik.me/autoscaling/addon-resizer:1.8.14"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/cluster-autoscaler:v1.21.2" target-image="test.embik.me/autoscaling/cluster-autoscaler:v1.21.2"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/cluster-autoscaler:v1.22.2" target-image="test.embik.me/autoscaling/cluster-autoscaler:v1.22.2"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/cluster-autoscaler:v1.23.0" target-image="test.embik.me/autoscaling/cluster-autoscaler:v1.23.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/cluster-autoscaler:v1.24.0" target-image="test.embik.me/autoscaling/cluster-autoscaler:v1.24.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/vpa-admission-controller:0.10.0" target-image="test.embik.me/autoscaling/vpa-admission-controller:0.10.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/vpa-recommender:0.10.0" target-image="test.embik.me/autoscaling/vpa-recommender:0.10.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/autoscaling/vpa-updater:0.10.0" target-image="test.embik.me/autoscaling/vpa-updater:0.10.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/coredns/coredns:v1.8.0" target-image="test.embik.me/coredns/coredns:v1.8.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/coredns/coredns:v1.8.4" target-image="test.embik.me/coredns/coredns:v1.8.4"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/dns/k8s-dns-node-cache:1.21.1" target-image="test.embik.me/dns/k8s-dns-node-cache:1.21.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/ingress-nginx/controller:v1.2.1@sha256:5516d103a9c2ecc4f026efbd4b40662ce22dc1f824fb129ed121460aaa5c47f8" target-image="test.embik.me/ingress-nginx/controller:v1.2.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/ingress-nginx/kube-webhook-certgen:v1.1.1@sha256:64d8c73dca984af206adf9d6d7e46aa550362b1d7a01f3a0a91b20cc67868660" target-image="test.embik.me/ingress-nginx/kube-webhook-certgen:v1.1.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.21.12" target-image="test.embik.me/kube-apiserver:v1.21.12"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.21.8" target-image="test.embik.me/kube-apiserver:v1.21.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.22.11" target-image="test.embik.me/kube-apiserver:v1.22.11"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.22.5" target-image="test.embik.me/kube-apiserver:v1.22.5"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.22.9" target-image="test.embik.me/kube-apiserver:v1.22.9"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.23.6" target-image="test.embik.me/kube-apiserver:v1.23.6"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.23.8" target-image="test.embik.me/kube-apiserver:v1.23.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.24.0" target-image="test.embik.me/kube-apiserver:v1.24.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-apiserver:v1.24.2" target-image="test.embik.me/kube-apiserver:v1.24.2"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.21.12" target-image="test.embik.me/kube-controller-manager:v1.21.12"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.21.8" target-image="test.embik.me/kube-controller-manager:v1.21.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.22.11" target-image="test.embik.me/kube-controller-manager:v1.22.11"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.22.5" target-image="test.embik.me/kube-controller-manager:v1.22.5"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.22.9" target-image="test.embik.me/kube-controller-manager:v1.22.9"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.23.6" target-image="test.embik.me/kube-controller-manager:v1.23.6"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.23.8" target-image="test.embik.me/kube-controller-manager:v1.23.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.24.0" target-image="test.embik.me/kube-controller-manager:v1.24.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-controller-manager:v1.24.2" target-image="test.embik.me/kube-controller-manager:v1.24.2"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.21.12" target-image="test.embik.me/kube-proxy:v1.21.12"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.21.8" target-image="test.embik.me/kube-proxy:v1.21.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.22.11" target-image="test.embik.me/kube-proxy:v1.22.11"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.22.5" target-image="test.embik.me/kube-proxy:v1.22.5"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.22.9" target-image="test.embik.me/kube-proxy:v1.22.9"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.23.6" target-image="test.embik.me/kube-proxy:v1.23.6"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.23.8" target-image="test.embik.me/kube-proxy:v1.23.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.24.0" target-image="test.embik.me/kube-proxy:v1.24.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-proxy:v1.24.2" target-image="test.embik.me/kube-proxy:v1.24.2"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.21.12" target-image="test.embik.me/kube-scheduler:v1.21.12"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.21.8" target-image="test.embik.me/kube-scheduler:v1.21.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.22.11" target-image="test.embik.me/kube-scheduler:v1.22.11"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.22.5" target-image="test.embik.me/kube-scheduler:v1.22.5"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.22.9" target-image="test.embik.me/kube-scheduler:v1.22.9"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.23.6" target-image="test.embik.me/kube-scheduler:v1.23.6"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.23.8" target-image="test.embik.me/kube-scheduler:v1.23.8"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.24.0" target-image="test.embik.me/kube-scheduler:v1.24.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-scheduler:v1.24.2" target-image="test.embik.me/kube-scheduler:v1.24.2"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-state-metrics/kube-state-metrics:v2.1.1" target-image="test.embik.me/kube-state-metrics/kube-state-metrics:v2.1.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/kube-state-metrics/kube-state-metrics:v2.5.0" target-image="test.embik.me/kube-state-metrics/kube-state-metrics:v2.5.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/metrics-server-amd64:v0.2.1" target-image="test.embik.me/metrics-server-amd64:v0.2.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/metrics-server/metrics-server:v0.6.1" target-image="test.embik.me/metrics-server/metrics-server:v0.6.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-attacher:v3.2.1" target-image="test.embik.me/sig-storage/csi-attacher:v3.2.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-attacher:v3.4.0" target-image="test.embik.me/sig-storage/csi-attacher:v3.4.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.2.0" target-image="test.embik.me/sig-storage/csi-node-driver-registrar:v2.2.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.5.0" target-image="test.embik.me/sig-storage/csi-node-driver-registrar:v2.5.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-provisioner:v2.2.2" target-image="test.embik.me/sig-storage/csi-provisioner:v2.2.2"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0" target-image="test.embik.me/sig-storage/csi-provisioner:v3.1.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-resizer:v1.2.0" target-image="test.embik.me/sig-storage/csi-resizer:v1.2.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-resizer:v1.4.0" target-image="test.embik.me/sig-storage/csi-resizer:v1.4.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/csi-snapshotter:v5.0.1" target-image="test.embik.me/sig-storage/csi-snapshotter:v5.0.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/livenessprobe:v2.3.0" target-image="test.embik.me/sig-storage/livenessprobe:v2.3.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/livenessprobe:v2.6.0" target-image="test.embik.me/sig-storage/livenessprobe:v2.6.0"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/snapshot-controller:v5.0.1" target-image="test.embik.me/sig-storage/snapshot-controller:v5.0.1"
INFO[14:59:52] Image found                                   source-image="k8s.gcr.io/sig-storage/snapshot-validation-webhook:v5.0.1" target-image="test.embik.me/sig-storage/snapshot-validation-webhook:v5.0.1"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/k8s/csi/azuredisk-csi:v1.18.0" target-image="test.embik.me/k8s/csi/azuredisk-csi:v1.18.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/k8s/csi/azurefile-csi:v1.18.0" target-image="test.embik.me/k8s/csi/azurefile-csi:v1.18.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes-csi/csi-attacher:v3.4.0" target-image="test.embik.me/oss/kubernetes-csi/csi-attacher:v3.4.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes-csi/csi-node-driver-registrar:v2.5.0" target-image="test.embik.me/oss/kubernetes-csi/csi-node-driver-registrar:v2.5.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes-csi/csi-provisioner:v3.1.0" target-image="test.embik.me/oss/kubernetes-csi/csi-provisioner:v3.1.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes-csi/csi-resizer:v1.4.0" target-image="test.embik.me/oss/kubernetes-csi/csi-resizer:v1.4.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes-csi/csi-snapshotter:v5.0.1" target-image="test.embik.me/oss/kubernetes-csi/csi-snapshotter:v5.0.1"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.6.0" target-image="test.embik.me/oss/kubernetes-csi/livenessprobe:v2.6.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes-csi/snapshot-controller:v5.0.1" target-image="test.embik.me/oss/kubernetes-csi/snapshot-controller:v5.0.1"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-controller-manager:v1.0.18" target-image="test.embik.me/oss/kubernetes/azure-cloud-controller-manager:v1.0.18"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-controller-manager:v1.1.14" target-image="test.embik.me/oss/kubernetes/azure-cloud-controller-manager:v1.1.14"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-controller-manager:v1.23.11" target-image="test.embik.me/oss/kubernetes/azure-cloud-controller-manager:v1.23.11"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-controller-manager:v1.24.0" target-image="test.embik.me/oss/kubernetes/azure-cloud-controller-manager:v1.24.0"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.0.19" target-image="test.embik.me/oss/kubernetes/azure-cloud-node-manager:v1.0.19"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.1.15" target-image="test.embik.me/oss/kubernetes/azure-cloud-node-manager:v1.1.15"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.23.12" target-image="test.embik.me/oss/kubernetes/azure-cloud-node-manager:v1.23.12"
INFO[14:59:52] Image found                                   source-image="mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.24.0" target-image="test.embik.me/oss/kubernetes/azure-cloud-node-manager:v1.24.0"
INFO[14:59:52] Image found                                   source-image="projects.registry.vmware.com/vmware-cloud-director/cloud-director-named-disk-csi-driver:1.2.0.latest" target-image="test.embik.me/vmware-cloud-director/cloud-director-named-disk-csi-driver:1.2.0.latest"
INFO[14:59:52] Image found                                   source-image="quay.io/brancz/kube-rbac-proxy:v0.11.0" target-image="test.embik.me/brancz/kube-rbac-proxy:v0.11.0"
INFO[14:59:52] Image found                                   source-image="quay.io/brancz/kube-rbac-proxy:v0.12.0" target-image="test.embik.me/brancz/kube-rbac-proxy:v0.12.0"
INFO[14:59:52] Image found                                   source-image="quay.io/cilium/certgen:v0.1.5" target-image="test.embik.me/cilium/certgen:v0.1.5"
INFO[14:59:52] Image found                                   source-image="quay.io/cilium/cilium:v1.11.0@sha256:ea677508010800214b0b5497055f38ed3bff57963fa2399bcb1c69cf9476453a" target-image="test.embik.me/cilium/cilium:v1.11.0"
INFO[14:59:52] Image found                                   source-image="quay.io/cilium/hubble-relay:v1.11.0@sha256:306ce38354a0a892b0c175ae7013cf178a46b79f51c52adb5465d87f14df0838" target-image="test.embik.me/cilium/hubble-relay:v1.11.0"
INFO[14:59:52] Image found                                   source-image="quay.io/cilium/hubble-ui-backend:v0.8.3@sha256:13a16ed3ae9749682c817d3b834b2f2de901da6fb41de7753d7dce16650982b3" target-image="test.embik.me/cilium/hubble-ui-backend:v0.8.3"
INFO[14:59:52] Image found                                   source-image="quay.io/cilium/hubble-ui:v0.8.3@sha256:018ed122968de658d8874e2982fa6b3a8ae64b43d2356c05f977004176a89310" target-image="test.embik.me/cilium/hubble-ui:v0.8.3"
INFO[14:59:52] Image found                                   source-image="quay.io/cilium/operator-generic:v1.11.0@sha256:b522279577d0d5f1ad7cadaacb7321d1b172d8ae8c8bc816e503c897b420cfe3" target-image="test.embik.me/cilium/operator-generic:v1.11.0"
INFO[14:59:52] Image found                                   source-image="quay.io/coreos/flannel:v0.11.0" target-image="test.embik.me/coreos/flannel:v0.11.0"
INFO[14:59:52] Image found                                   source-image="quay.io/coreos/flannel:v0.15.1" target-image="test.embik.me/coreos/flannel:v0.15.1"
INFO[14:59:52] Image found                                   source-image="quay.io/jetstack/cert-manager-cainjector:v1.8.0" target-image="test.embik.me/jetstack/cert-manager-cainjector:v1.8.0"
INFO[14:59:52] Image found                                   source-image="quay.io/jetstack/cert-manager-controller:v1.8.0" target-image="test.embik.me/jetstack/cert-manager-controller:v1.8.0"
INFO[14:59:52] Image found                                   source-image="quay.io/jetstack/cert-manager-webhook:v1.8.0" target-image="test.embik.me/jetstack/cert-manager-webhook:v1.8.0"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/addons:899058316c255df97b91b6912156038a89f29fc3" target-image="test.embik.me/kubermatic/addons:899058316c255df97b91b6912156038a89f29fc3"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/dashboard-ee:NA" target-image="test.embik.me/kubermatic/dashboard-ee:NA"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/grafana-plugins:1.3.1" target-image="test.embik.me/kubermatic/grafana-plugins:1.3.1"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/http-prober:v0.3.3" target-image="test.embik.me/kubermatic/http-prober:v0.3.3"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/kubeletdnat-controller:899058316c255df97b91b6912156038a89f29fc3" target-image="test.embik.me/kubermatic/kubeletdnat-controller:899058316c255df97b91b6912156038a89f29fc3"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/kubermatic-ee:899058316c255df97b91b6912156038a89f29fc3" target-image="test.embik.me/kubermatic/kubermatic-ee:899058316c255df97b91b6912156038a89f29fc3"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/kubermatic:v9.9.9-dev" target-image="test.embik.me/kubermatic/kubermatic:v9.9.9-dev"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/kubevirt-csi-driver-operator:v0.1.0" target-image="test.embik.me/kubermatic/kubevirt-csi-driver-operator:v0.1.0"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/machine-controller:v1.51.0" target-image="test.embik.me/kubermatic/machine-controller:v1.51.0"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/nodeport-proxy:899058316c255df97b91b6912156038a89f29fc3" target-image="test.embik.me/kubermatic/nodeport-proxy:899058316c255df97b91b6912156038a89f29fc3"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/openvpn:v2.5.2-r0" target-image="test.embik.me/kubermatic/openvpn:v2.5.2-r0"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/operating-system-manager:v0.4.3" target-image="test.embik.me/kubermatic/operating-system-manager:v0.4.3"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/s3-exporter:v0.6" target-image="test.embik.me/kubermatic/s3-exporter:v0.6"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/telemetry-agent:v0.2.2" target-image="test.embik.me/kubermatic/telemetry-agent:v0.2.2"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/user-ssh-keys-agent:899058316c255df97b91b6912156038a89f29fc3" target-image="test.embik.me/kubermatic/user-ssh-keys-agent:899058316c255df97b91b6912156038a89f29fc3"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/util:2.1.0" target-image="test.embik.me/kubermatic/util:2.1.0"
INFO[14:59:52] Image found                                   source-image="quay.io/kubermatic/web-terminal:0.2.0" target-image="test.embik.me/kubermatic/web-terminal:0.2.0"
INFO[14:59:52] Image found                                   source-image="quay.io/prometheus/alertmanager:v0.24.0" target-image="test.embik.me/prometheus/alertmanager:v0.24.0"
INFO[14:59:52] Image found                                   source-image="quay.io/prometheus/blackbox-exporter:v0.21.0" target-image="test.embik.me/prometheus/blackbox-exporter:v0.21.0"
INFO[14:59:52] Image found                                   source-image="quay.io/prometheus/node-exporter:v1.2.2" target-image="test.embik.me/prometheus/node-exporter:v1.2.2"
INFO[14:59:52] Image found                                   source-image="quay.io/prometheus/node-exporter:v1.3.1" target-image="test.embik.me/prometheus/node-exporter:v1.3.1"
INFO[14:59:52] Image found                                   source-image="quay.io/prometheus/prometheus:v2.34.0" target-image="test.embik.me/prometheus/prometheus:v2.34.0"
INFO[14:59:52] Image found                                   source-image="quay.io/prometheus/prometheus:v2.35.0" target-image="test.embik.me/prometheus/prometheus:v2.35.0"

Example error output:

./_build/kubermatic-installer --charts-directory charts/ mirror-images --config ~/Workspace/deployments/kkp-2.20/kubermatic.yaml --addons-path ./addons test.embik.me
INFO[15:01:19] 🚀 Collecting images…
INFO[15:01:31] 🚀 Rendering Helm charts…                      charts-directory=charts/
INFO[15:01:35] Downloading image…                            image="anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1"
INFO[15:01:35] Executing command…                            command="docker pull anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1" image="anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1"
ERRO[15:01:35] Command failed:                               command="docker pull anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1" image="anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1"
ERRO[15:01:35] ❌ Operation failed: failed to process images: failed to download all images: failed to download anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1: failed to pull image anx-cr.io/anexia/anx-cloud-controller-manager:1.4.1: exec: "docker": executable file not found in $PATH.

@embik
Add existing test cases for image-loader into pkg/install/images
2ac7bc2 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
gimps
1d894db 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Stop shipping 'tools' archive with KKP releases
4a45c9e 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik requested a review from xrstf June 21, 2022 15:10
@embik embik mentioned this pull request Jun 22, 2022
Merged
@embik
Remove compat flags
80af123 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
xrstf
xrstf approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ery Ice!

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f3fcdc6c431277a1388d80b5ddda4fd3b5871cc

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@embik
Copy link
Member Author

embik commented Jun 22, 2022

/hold

vSphere won't succeed any time soon.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2022
@embik
Copy link
Member Author

embik commented Jun 22, 2022

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 5e21dc2 into kubermatic:master Jun 22, 2022
@embik embik deleted the kkp-installer-mirror-images branch June 23, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move image-loader functionality to a subcommand of kubermatic-installer
4 participants
@embik @kubermatic-bot @kubermatic-triage-bot @xrstf