New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag -o/--output to kubermatic-installer to allow json output #10137
Add a flag -o/--output to kubermatic-installer to allow json output #10137
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/retest |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Not sure what's so neat about this in this case, but I only have minor things to mention:
|
I was thinking about that, but since we're already doing different logging in the installer, I thought offering something that looks more like other Kubernetes client applications was better. I don't have strong opinions about that though, I can change it if you prefer it to be consistent.
I don't think that's an issue 🤷🏻 |
/approve I wish we had telemetry to tell us how many users discovered and then used the JSON output in the future :D |
LGTM label has been added. Git tree hash: f3d82d414ce7700c7a978a72f8f108cb5796dd9b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Review the full test history Silence the bot with an |
1 similar comment
/retest Review the full test history Silence the bot with an |
What does this PR do / Why do we need it:
Not sure if we want to merge this, but I thought it would be neat to have the option for json log formatting in
kubermatic-installer
. The default of course stays with the nice formatter that logrus uses for human readability (filled under "console" in this new flag), but an--output
(or shorthand-o
) flag will allow to get json output if that is wanted (I can see this being useful with the upcomingmirror-images
subcommand, for example).This is what it would look like, as an example for an early failure on deploying:
WDYT?
Does this PR close any issues?:
Fixes #
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?:
Signed-off-by: Marvin Beckers marvin@kubermatic.com