New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve etcd backup filenames #10143
Improve etcd backup filenames #10143
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q
LGTM label has been added. Git tree hash: a8f558c2a6edc7bb6ddb8bcff4c126868619d9fc
|
/retest |
/cherry-pick release/v2.19 |
@dharapvj: #10143 failed to apply on top of branch "release/v2.19":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v2.20 |
@dharapvj: #10143 failed to apply on top of branch "release/v2.20":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* do not use colons in legacy backup file names to increase compatibility with some S3 backends * do not create backup files without extension
What does this PR do / Why do we need it:
Not all S3 backends can handle files with colons (:) in them, apparently. Also it's hard to use the files because no file extension is present and you're not even sure if it's a tar.gz of the etcd or not.
This PR addresses both points. Existing backups should be untouched, but new ones should be more compatible.
Does this PR close any issues?:
Fixes #7337
Does this PR introduce a user-facing change?: