Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log levels #10325

Merged
merged 1 commit into from Jul 14, 2022
Merged

Fix log levels #10325

merged 1 commit into from Jul 14, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jul 13, 2022 •
edited

What does this PR do / Why do we need it:
We should use the INFO log level only for actionable messages, like when we actually created/deleted a resource. There is little use (IMHO) to log "Skipping reconcile for StatefulSets, is not healthy yet" over and over again. So this PR changes all log statements that used INFO to DEBUG if they only log non-essential progress information.

I also, randomly, replaced Eventf() with Event() where we don't actually do string formatting.

Does this PR introduce a user-facing change?:

Improve log verbosity

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2022
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2022
@xrstf
Copy link
Contributor Author

xrstf commented Jul 13, 2022

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 🏎️

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54ab1e0ec26c93d92147378072ecd14180e7e839

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@xrstf
Copy link
Contributor Author

xrstf commented Jul 14, 2022

/override pre-kubermatic-test-integration

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pre-kubermatic-test-integration

In response to this:

/override pre-kubermatic-test-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor Author

xrstf commented Jul 14, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit cfa7442 into kubermatic:master Jul 14, 2022
@xrstf xrstf deleted the fix-log-levels branch July 14, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrstf @kubermatic-bot @kubermatic-triage-bot @ahmedwaleedmalik