Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI driver for DigitalOcean #10375

Merged
merged 2 commits into from Jul 21, 2022
Merged

CSI driver for DigitalOcean #10375

merged 2 commits into from Jul 21, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What does this PR do / Why do we need it:
Implement support for DigitalOcean CSI driver.

Does this PR close any issues?:
Fixes #10367

Special notes for your reviewer:
CCM support for DigitalOcean should be covered under #8847

Documentation:

Does this PR introduce a user-facing change?:

CSI driver for DigitalOcean

@ahmedwaleedmalik
CSI driver for DigitalOcean
c2b250d 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 18, 2022
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 18, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.24

@ahmedwaleedmalik ahmedwaleedmalik removed the request for review from xrstf July 18, 2022 11:16
@ahmedwaleedmalik ahmedwaleedmalik changed the title CSI driver for DigitalOcean WIP: CSI driver for DigitalOcean Jul 18, 2022
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2022
@ahmedwaleedmalik
Copy link
Member Author

It seems like my last-moment changes caused some issues, I've moved this back to WIP.

@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: CSI driver for DigitalOcean CSI driver for DigitalOcean Jul 18, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.24

@ahmedwaleedmalik
CSI driver for DigitalOcean
6c8cdcb 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.24

@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.24

Looks like a flake 😨

@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.24

xrstf
xrstf approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 287013575e6cb4db3cb06987960da5a0c1b53a4b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit c3b81d0 into kubermatic:master Jul 21, 2022
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement support for DigitalOcean CSI driver
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf