Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match public IP address SKU to load balancer SKU for Azure #10678

Merged
merged 3 commits into from Aug 22, 2022
Merged

Match public IP address SKU to load balancer SKU for Azure #10678

merged 3 commits into from Aug 22, 2022

Conversation

embik
Copy link
Member

@embik embik commented Aug 4, 2022 •
edited

What does this PR do / Why do we need it:

This PR fixes an issue with the standard load balancer SKU that apparently went unnoticed since #7208: When running with that LB SKU and using public IPs on your nodes, the public IP address SKU not matching the LB SKU will fail load balancer reconciliation.

Through a new field in Azure's cloud spec in MC, the IP address SKU can now be set (previously, it was defaulted to basic unless dualstack was used). This PR defaults the IP address SKU on any MachineDeployment to standard to match the LB.

This needs a new MC release, so the PR is a draft and there's an override for a fresh MC commit.

I also took the liberty to upgrade our conformance test scenarios to the standard LB. It's the SKU recommended by Azure anyway.

Does this PR close any issues?:
Fixes #10673

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

When using the "standard" load balancer SKU for Azure clusters, MachineDeployments use the same SKU for public IP addresses

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 4, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Aug 4, 2022
@embik
Copy link
Member Author

embik commented Aug 4, 2022

/test pre-kubermatic-e2e-azure-ubuntu-1.24

@embik embik changed the title Match LB SKU for public IP address SKU for Azure Match public IP address SKU to load balancer SKU for Azure Aug 4, 2022
@embik embik added this to the KKP 2.21 milestone Aug 4, 2022
@ahmedwaleedmalik
Copy link
Member

@embik can we move forward with this one? :D

@embik
Copy link
Member Author

embik commented Aug 16, 2022

@embik can we move forward with this one? :D

There's still no MC release that includes the necessary fields ...

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2022
@embik
Temporarily pin machine-controller and set PublicIPSKU for standard L…
77b7769 
…B clusters

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Run conformance tests for 'standard' Azure LB SKU
1188856 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Rebase and pin machine-controller
d1f48e6 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik marked this pull request as ready for review August 22, 2022 07:29
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2022
@embik
Copy link
Member Author

embik commented Aug 22, 2022

/test pre-kubermatic-e2e-azure-ubuntu-1.24

@embik
Copy link
Member Author

embik commented Aug 22, 2022

/retest

1 similar comment
@embik
Copy link
Member Author

embik commented Aug 22, 2022

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aeb226e50002d5b9411aa99c8aad73c62d9c80ee

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 201b59f into kubermatic:master Aug 22, 2022
@embik embik deleted the azure-lb-match-ip-sku branch August 22, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.21
Development

Successfully merging this pull request may close these issues.

Public IP SKU does not match Load Balancer SKU when using standard LBs in Azure
3 participants
@embik @kubermatic-bot @ahmedwaleedmalik