Add EnableIngressHostname and IngressHostnameSuffix options to Openstack cloud spec #10751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
kind/feature
|
Skipping CI for Draft Pull Request. |
kubermatic-bot
added
approved
|
/test pre-kubermatic-e2e-openstack-ubuntu-1.24 |
kubermatic-bot
added
release-note
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
sig/api
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
/test pre-kubermatic-e2e-openstack-ubuntu-1.24 |
|
/retest |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
LGTM label has been added. Git tree hash: 763e1ebbd8714b2548a712dcf2b0e54adf88a84a
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, embik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Openstack CCM has some workaround for using the PROXY protocol, as using that on a load balancer seems to break when you try to connect to the public IP from another node or pod in the cluster (so in-cluster components cannot talk to the service). The workaround seems to set up a dummy DNS name on the LoadBalancer service. That is configured by
enable-ingress-hostnameandingress-hostname-suffix. See upstream docs for details on these options.Upstream might remove this in the future once Kubernetes fixes the root issue via KEP-1860, so we should be ready to deprecate and remove this option in the future.
Which issue(s) this PR fixes:
Fixes #10706
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: