Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vsphere improved-csi-idempotency #10771

Merged

Conversation

mate4st
Copy link
Contributor

@mate4st mate4st commented Aug 16, 2022

What this PR does / why we need it:

Disables improved-csi-idempotency as it requires the csi driver to run in vmware-system-csi namespace.

Which issue(s) this PR fixes:

Fixes #10719

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix an issue with vsphere csi driver using improved-csi-idempotency that's currently not supported by KKP.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2022
@mate4st
Copy link
Contributor Author

mate4st commented Aug 17, 2022

/retest

@mate4st
Copy link
Contributor Author

mate4st commented Aug 17, 2022

/cherrypick release/v2.19

@kubermatic-bot
Copy link
Contributor

@WeirdMachine: once the present PR merges, I will cherry-pick it on top of release/v2.19 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mate4st
Copy link
Contributor Author

mate4st commented Aug 17, 2022

/cherrypick release/v2.20

@kubermatic-bot
Copy link
Contributor

@WeirdMachine: once the present PR merges, I will cherry-pick it on top of release/v2.20 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mate4st mate4st added this to the KKP 2.21 milestone Aug 17, 2022
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ba5ec167148cfd7e72a0e7b5b9076904f63322e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, WeirdMachine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit a25b3a0 into kubermatic:master Aug 18, 2022
@kubermatic-bot
Copy link
Contributor

@WeirdMachine: #10771 failed to apply on top of branch "release/v2.19":

Applying: disable vsphere improved-csi-idempotency
Using index info to reconstruct a base tree...
M	addons/csi/vsphere/vsphere-csi-driver.yaml
Falling back to patching base and 3-way merge...
Auto-merging addons/csi/vsphere/vsphere-csi-driver.yaml
CONFLICT (content): Merge conflict in addons/csi/vsphere/vsphere-csi-driver.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable vsphere improved-csi-idempotency
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@WeirdMachine: #10771 failed to apply on top of branch "release/v2.20":

Applying: disable vsphere improved-csi-idempotency
Using index info to reconstruct a base tree...
M	addons/csi/vsphere/vsphere-csi-driver.yaml
Falling back to patching base and 3-way merge...
Auto-merging addons/csi/vsphere/vsphere-csi-driver.yaml
CONFLICT (content): Merge conflict in addons/csi/vsphere/vsphere-csi-driver.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable vsphere improved-csi-idempotency
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mate4st
Copy link
Contributor Author

mate4st commented Aug 18, 2022

#10793
#10792

@mate4st mate4st deleted the disable-vsphere-csi-idempotency branch October 21, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsphere csi addon - vmware-system-csi namespace mandate
4 participants