[release/v2.21] Anexia: allow extended disk configuration in AnexiaNodeSpec #10916
Conversation
This extends apiv1.AnexiaNodeSpec to allow extended disk configuration introduced in machine-controller with pull request 1402 (kubermatic/machine-controller#1402). Without this, Kubermatic API returns a 500 when trying to do any MachineDeployment operation on a cluster which has a MachineDeployment with the new disks attribute (and thus without the old diskSize attribute). Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Setting the OperatingSystemSpec on the NodeSpec given into machine.GetAnexiaProviderConfig() does not actually do anything with the OS spec, instead, when creating the MachineDeployment, another one is created - completely ignoring us having set the ProvisioningUtility to CloudInit. This fixes that problem by copying the relevant code from the baseScenario.createMachineDeployment method and modifying the OS spec given to the createMachineDeployment() function. Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
OperatingSystemSpec directly contains the config attributes for the
given operating system, but was wrong encoded as
{"$operatingSystem": {$OperatingSystemSpec...}}
This fixes that issue by adding another switch-case over all known
operating systems. Should probably be done in a better way, but need
this done already..
Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
kubermatic-bot
added
kind/bug
|
Hi @LittleFox94. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LittleFox94
changed the title
|
/ok-to-test |
kubermatic-bot
added
ok-to-test
|
/retest |
|
/retry |
|
/retest ... oops |
|
/retest |
1 similar comment
|
/retest |
|
If I read the failure correctly, it needs #10918 backported to release/v2.21 and this branch rebased on that backport I could cherry-pick that commit into this branch here, but it's very unrelated changes and I'd like to avoid that - but it's your repo :) |
|
@LittleFox94 Ha seems like your PRs have been having a really bad time due to our vSphere infrastructure. I'm taking care of backporting #10918. I'll re-run the failing tests on your PRs once the backports are in. |
|
/retest |
|
LGTM label has been added. Git tree hash: 5cd08e5d3de66653deea981bcf735ed9f6e89f8a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, LittleFox94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
What this PR does / why we need it:
This extends
apiv1.AnexiaNodeSpecto allow extended disk configuration introduced in machine-controller with kubermatic/machine-controller#1402.Without this, Kubermatic API returns a 500 when trying to do any
MachineDeploymentoperation on a cluster which has aMachineDeploymentwith the newdisksattribute (and thus without the olddiskSizeattribute).Backport of #10816
What type of PR is this?
/kind bug
/kind feature
/kind api-change
It's a bug (500 error) because of a new feature, which causes and api-change
Special notes for your reviewer:
Comments on the machine-controller PRs:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: