Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.21] remove docker image digests in addons #11239

Merged
merged 1 commit into from Oct 27, 2022
Merged

[release/v2.21] remove docker image digests in addons #11239

merged 1 commit into from Oct 27, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 27, 2022

What this PR does / why we need it:
#11147 fixed the digest handling proper, but for the existing releases we do not want to backport the rather large change, but instead only just remove the digests. See the linked PR for more details as to why.

/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove digests from Docker images in addon manifests to fix issues with Docker registry mirrors / local registries. KKP 2.22  will restore the digests and properly support them.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2022
@xrstf xrstf requested a review from rastislavs October 27, 2022 11:12
@rastislavs
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b0372a5c1f661ef0abec339266700a83b186b001

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rastislavs, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit e166303 into kubermatic:release/v2.21 Oct 27, 2022
@xrstf xrstf deleted the fix-cilium-digests branch October 27, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs Awaiting requested review from rastislavs

Assignees

@rastislavs rastislavs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @rastislavs @kubermatic-bot