Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overwriteCloudConfigSpec from vSphere MDs #11315

Merged
merged 1 commit into from Nov 10, 2022
Merged

Remove overwriteCloudConfigSpec from vSphere MDs #11315

merged 1 commit into from Nov 10, 2022

Conversation

moadqassem
Copy link
Member

What this PR does / why we need it:
Machine deployment for vSphere, contains the credentials for vcenter, written explicitly. This pr removes that overwriteCloudSpec field and rely only on the OSM configs

Which issue(s) this PR fixes:

Fixes ##4974

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove the overwriteCloudSpec field from vSphere Machine Deployment

Documentation:

None

@moadqassem
remove overwriteCloudConfigSpec from vSphere MDs
6d022ab 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2022
@moadqassem
Copy link
Member Author

/hold DON'T MERGE

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@moadqassem moadqassem requested a review from xrstf November 8, 2022 00:53
@xrstf
Copy link
Contributor

xrstf commented Nov 8, 2022

rely only on the OSM configs

So without OSM, no more vSphere in KKP?

@moadqassem
Copy link
Member Author

rely only on the OSM configs

So without OSM, no more vSphere in KKP?

@xrstf No, there will be, this is what I mentioned today in the morning. This implementation will rely on OSM from KKP point of view. When OSM isn't enabled, machine controller will detect that, and fallback to the previous(actually current) implementation.

xrstf
xrstf approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d43e01f420baa735b7318ceabc3afb682e0bd65

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moadqassem
Copy link
Member Author

/retest

@moadqassem
Copy link
Member Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@xrstf
Copy link
Contributor

xrstf commented Nov 10, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit 8a9f4ab into kubermatic:main Nov 10, 2022
@embik
Copy link
Member

embik commented Nov 14, 2022

@moadqassem does this need to be backported to release branches?

@moadqassem moadqassem deleted the remove-cloud-config-from-machine-deployment branch February 14, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moadqassem @xrstf @kubermatic-bot @embik