Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AllowedRegistry ConstraintTemplate OpenAPI schema #11327

Merged
merged 1 commit into from Nov 10, 2022
Merged

fix AllowedRegistry ConstraintTemplate OpenAPI schema #11327

merged 1 commit into from Nov 10, 2022

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Nov 9, 2022 •
edited

What this PR does / why we need it:
fixes the allowedReigstry ConstraintTemplate OpenApiSchema.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fixed the issue where AllowedRegistry ConstraintTemplate was not being reconiciled by Gatekeeper because it's `spec.crd` OpenAPI spec was missing a type.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. labels Nov 9, 2022
@lsviben lsviben changed the title fix AllowedRegistry ConstraintTemplate openapi schema fix AllowedRegistry ConstraintTemplate OpenAPI schema Nov 9, 2022
@lsviben lsviben force-pushed the fix-allowedregistry-constraint-template branch from ef9464f to acff115 Compare November 9, 2022 13:27
@rastislavs
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f5540f7db02d7b110a2cc0099757b445a8648ec

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retest

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, lsviben, rastislavs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 6d9ac9f into kubermatic:main Nov 10, 2022
@embik
Copy link
Member

embik commented Nov 14, 2022

@lsviben does this need to be backported to releases?

@lsviben
Copy link
Contributor Author

lsviben commented Nov 14, 2022

@lsviben does this need to be backported to releases?

yeah, just to 2.21 though.

/cherrypick release/v2.21

@kubermatic-bot kubermatic-bot mentioned this pull request Nov 14, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@lsviben: new pull request created: #11355

In response to this:

@lsviben does this need to be backported to releases?

yeah, just to 2.21 though.

/cherrypick release/v2.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik embik added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label Nov 14, 2022
@embik
Copy link
Member

embik commented Nov 14, 2022

Thanks!

@embik
Copy link
Member

embik commented Nov 14, 2022

Maybe we can also update the release note to include information that we will include in release notes (for 2.22 and 2.21.x)?

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 14, 2022
@lsviben
Copy link
Contributor Author

lsviben commented Nov 14, 2022

Maybe we can also update the release note to include information that we will include in release notes (for 2.22 and 2.21.x)?

good point, i missed the release note. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@rastislavs rastislavs Awaiting requested review from rastislavs

Assignees

@rastislavs rastislavs

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lsviben @rastislavs @kubermatic-bot @embik @ahmedwaleedmalik