Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.20] Use registry.k8s.io instead of k8s.gcr.io for Kubernetes upstream images #11391

Merged
merged 5 commits into from Dec 8, 2022
Merged

[release/v2.20] Use registry.k8s.io instead of k8s.gcr.io for Kubernetes upstream images #11391

merged 5 commits into from Dec 8, 2022

Conversation

embik
Copy link
Member

@embik embik commented Nov 21, 2022 •
edited

What this PR does / why we need it:
Kubernetes upstream introduced a new registry URL called registry.k8s.io, which acts as a kind of proxy (well, technically it only redirects) for upstream images. This can speed up the image pull process if a local mirror is available that you're forwarded to (mainly on AWS, as far as I understand from upstream documentation) and is the suggested source of images now. Let's switch to it.

This is a manual cherry-pick of #11079.

Which issue(s) this PR fixes:

Towards #9987

What type of PR is this?
/kind cleanup
/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

ACTION REQUIRED: Use `registry.k8s.io` instead of `k8s.gcr.io` for Kubernetes upstream images. It might be necessary to update firewall rules or mirror registries accordingly

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2022
@embik
Copy link
Member Author

embik commented Nov 23, 2022

/retest

xrstf
xrstf approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aef6b976adfbe8f8a4cd15bbc876b36188b9d282

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@embik
Copy link
Member Author

embik commented Nov 23, 2022

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2022
@embik
Replace k8s.gcr.io with registry.k8s.io in addons
ee2c1e6 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Change resources from k8s.gcr.io to registry.k8s.io
86f1be7 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Update fixtures
a2390b7 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Update remaining updates
deb360d 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@embik
Copy link
Member Author

embik commented Dec 6, 2022

/retest

1 similar comment
@embik
Copy link
Member Author

embik commented Dec 7, 2022

/retest

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 7, 2022
@embik
Copy link
Member Author

embik commented Dec 7, 2022

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022
@embik
Copy link
Member Author

embik commented Dec 7, 2022

/retest

@embik embik unassigned xrstf Dec 7, 2022
@embik
Copy link
Member Author

embik commented Dec 7, 2022

/retest

2 similar comments
@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
[release/v2.20] Use Ubuntu 20.04 image because 22.04 isn't supported
36ec374 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

4 similar comments
@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

ahmedwaleedmalik
ahmedwaleedmalik reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 👍

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0442f04b19c243d082e3c8144582c43e5d27e2b8

@embik embik added the cherry-pick-approved Indicates a PR has been approved by release managers. label Dec 8, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 8, 2022
@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

4 similar comments
@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@embik
Copy link
Member Author

embik commented Dec 8, 2022

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 89776b4 into kubermatic:release/v2.20 Dec 8, 2022
@embik embik deleted the registry-change-v2.20 branch October 20, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik left review comments

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@embik @kubermatic-bot @ahmedwaleedmalik @kubermatic-triage-bot @xrstf