Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.21] Unblock etcd backup/restore reconciliation #11854

Merged
merged 1 commit into from Feb 8, 2023
Merged

[release/v2.21] Unblock etcd backup/restore reconciliation #11854

merged 1 commit into from Feb 8, 2023

Conversation

pkprzekwas
Copy link
Contributor

@pkprzekwas pkprzekwas commented Feb 8, 2023 •
edited

What this PR does / why we need it:
Unblock etcd backup/restore reconciliation upon missing default backup destination.

This is a manual update as cherry-picking conflicted.

Which issue(s) this PR fixes:
Fixes #11833

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Unblock etcd backup controller's reconciliation loop in case `defaultDestination` field is missing on Seed CR.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2023
@pkprzekwas pkprzekwas requested a review from embik February 8, 2023 13:42
embik
embik approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cadc8aedf1b48078c62b78f95ab3e9c349a52eab

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, pkprzekwas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@pkprzekwas pkprzekwas added the cherry-pick-approved Indicates a PR has been approved by release managers. label Feb 8, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 8, 2023
@kubermatic-bot kubermatic-bot merged commit b759bac into kubermatic:release/v2.21 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pkprzekwas @kubermatic-bot @embik