Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add share cluster flag to kubermatic settings #11950

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Add share cluster flag to kubermatic settings #11950

merged 2 commits into from
Feb 27, 2023

Conversation

KhizerRehan
Copy link
Contributor

@KhizerRehan KhizerRehan commented Feb 23, 2023 •
edited by ahmedwaleedmalik

What this PR does / why we need it:
This PR adds a simple boolean flag to Kubermatic Settings CRD to allow to handle share cluster config from UI. This will allow to control share cluster kubeconfig button to be handled from Admin default settings page instead of providing defaulting from UI

Which issue(s) this PR fixes:

Fixes #11934

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Introduce EnableShareCluster flag in Kubermatic Settings to toggle the share cluster feature for the dashboard.
[ACTION REQUIRED] `share_kubeconfig` field in the UI configuration for KubermaticConfiguration has been replaced with `EnableShareCluster` flag in KubermaticSettings. `share_kubeconfig` is no-op and will be ignored by the dashboard.

Documentation:

TBD

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Feb 23, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2023
@KhizerRehan KhizerRehan changed the title WIP [release/v2.22@Next] Add feature flag for share cluster [WIP release/v2.22@next] Add feature flag for share cluster Feb 23, 2023
@KhizerRehan KhizerRehan force-pushed the 11934-share-cluster-feature-flag branch from 7f53f45 to d3501fd Compare February 23, 2023 08:43
@KhizerRehan
Copy link
Contributor Author

/test all

@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2023
@embik embik removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Feb 24, 2023
@KhizerRehan KhizerRehan force-pushed the 11934-share-cluster-feature-flag branch from b0d052d to 9fd79a5 Compare February 27, 2023 07:26
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/tbd Denotes a PR that needs documentation (change) that will be done later. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Feb 27, 2023
@KhizerRehan KhizerRehan changed the title [WIP release/v2.22@next] Add feature flag for share cluster Add share cluster flag to kubermatic settings Feb 27, 2023
@KhizerRehan KhizerRehan marked this pull request as ready for review February 27, 2023 07:34
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2023
@KhizerRehan KhizerRehan force-pushed the 11934-share-cluster-feature-flag branch from 9fd79a5 to c96f5bc Compare February 27, 2023 07:57
@KhizerRehan KhizerRehan force-pushed the 11934-share-cluster-feature-flag branch from c96f5bc to 7bf2176 Compare February 27, 2023 08:51
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 27, 2023
@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 27, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, KhizerRehan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c46429b6297f29964fca6465a141529e43511dbf

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Feb 27, 2023
Merged
@kubermatic-bot kubermatic-bot merged commit 1a43870 into kubermatic:main Feb 27, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.22 milestone Feb 27, 2023
@embik embik modified the milestones: KKP 2.22, KKP 2.23 Mar 6, 2023
@pkprzekwas pkprzekwas mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

Implement feature gate to enable/disable the share cluster
4 participants
@KhizerRehan @kubermatic-bot @ahmedwaleedmalik @embik