Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.20] Include tunneling agent IP in apiserver's TLS cert SAN #11956

Merged
merged 1 commit into from Mar 1, 2023
Merged

[release/v2.20] Include tunneling agent IP in apiserver's TLS cert SAN #11956

merged 1 commit into from Mar 1, 2023

Conversation

rastislavs
Copy link
Contributor

@rastislavs rastislavs commented Feb 24, 2023 •
edited

What this PR does / why we need it:

This is a manual backport of #11932 (#11933)

Which issue(s) this PR fixes:

Fixes #11930

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Include tunneling agent IP in apiserver's TLS cert SANs

Documentation:

NONE

@rastislavs
Include tunneling agent IP in apiserver's TLS cert SAN
1682fb2 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Feb 24, 2023
@rastislavs
Copy link
Contributor Author

/retest

4 similar comments
@rastislavs
Copy link
Contributor Author

/retest

@rastislavs
Copy link
Contributor Author

/retest

@embik
Copy link
Member

embik commented Feb 27, 2023

/retest

@embik
Copy link
Member

embik commented Feb 28, 2023

/retest

embik
embik approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c90e143de4a4c1a88fcc05ce4482544cb6743f7

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, rastislavs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@rastislavs
Copy link
Contributor Author

cc @kubermatic/sig-release-managers
This PR is ready for merging

@xrstf xrstf added cherry-pick-approved Indicates a PR has been approved by release managers. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 1, 2023
@kubermatic-bot kubermatic-bot merged commit 21c921d into kubermatic:release/v2.20 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rastislavs @embik @kubermatic-bot @xrstf