Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Loki compactor retention and rotation #12029

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

moelsayed
Copy link
Contributor

@moelsayed moelsayed commented Mar 10, 2023

What this PR does / why we need it:
Our current configuration doesn't enable Loki compactor. This PR enables the compactor by default to rotate old file and avoid running out of disk space.
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Enable Loki Compactor rotation and set retention to 1 month by default. 

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Mar 10, 2023
@embik
Copy link
Member

embik commented Mar 10, 2023

Nit: can we document the new default retention period in the release note and maybe even how to override it?

@dharapvj
Copy link
Contributor

👏 👏 👏

@dharapvj
Copy link
Contributor

dharapvj commented Mar 10, 2023

Do we still need to delete old files from some directory ... even after turning on compactor? @moelsayed - i kind of remember we did this when we were working through this? In that case - may be add that bit in release notes as well.

@wurbanski
Copy link
Contributor

wurbanski commented Mar 10, 2023

and maybe even how to override it?

well, we don't document any other features of Loki that the end user might want to customize using the chart to be fair :P
we're using an upstream loki chart which is a bit outdated at this moment so we might want to work on that later anyway...

edit: agree on adding a release note, though

@wurbanski
Copy link
Contributor

/lgtm

(please extend the release note in the description, it will be applied to the release note even if you do it later @moelsayed)

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5cf7927d3328d8006a4b38e2db3f346638814f15

@moelsayed
Copy link
Contributor Author

@dharapvj No need to remove files to enable this. We did that while working on it because we had ran out of space and Loki was failing to start. Normally that should be the case.

@wurbanski
Copy link
Contributor

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moelsayed, wurbanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@kubermatic-bot kubermatic-bot merged commit a16d851 into kubermatic:main Mar 10, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants