-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Loki compactor retention and rotation #12029
Conversation
Nit: can we document the new default retention period in the release note and maybe even how to override it? |
👏 👏 👏 |
Do we still need to delete old files from some directory ... even after turning on compactor? @moelsayed - i kind of remember we did this when we were working through this? In that case - may be add that bit in release notes as well. |
well, we don't document any other features of Loki that the end user might want to customize using the chart to be fair :P edit: agree on adding a release note, though |
/lgtm (please extend the release note in the description, it will be applied to the release note even if you do it later @moelsayed) |
LGTM label has been added. Git tree hash: 5cf7927d3328d8006a4b38e2db3f346638814f15
|
@dharapvj No need to remove files to enable this. We did that while working on it because we had ran out of space and Loki was failing to start. Normally that should be the case. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moelsayed, wurbanski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Our current configuration doesn't enable Loki compactor. This PR enables the compactor by default to rotate old file and avoid running out of disk space.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: