Installer: make helm chart deployment skippable

[marioreggiori]

What this PR does / why we need it:
This PR allows helm chart deployments to be skipped by the installers deploy command via --skip-charts flag.

Which issue(s) this PR fixes:

Fixes #5859

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Added --skip-charts flag to `kubermatic-installer deploy` command to make helm chart deployment skippable.

Documentation:

Run `kubermatic-installer deploy --help`.

[kubermatic-bot]

Hi @marioreggiori. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahmedwaleedmalik]

/ok-to-test
cc @xrstf

[ahmedwaleedmalik]

This looks good to me. Although personally, I would prefer to have it in the values file:

dex:
  disabled: true

But for that, we probably need an umbrella helm chart.

[marioreggiori]

I would prefer to have it in the values file

Would the dex.disabled field be handled by the installer (in go), or only via helm?
... I think it could be a little confusing if the installer would output "Deploying dex…" even though it was disabled

[embik]

I kind of like the solution proposed in this PR, thank you for it. A thought I had that I'd like to put up for discussion, should this flag also support --skip-charts='*' which would skip all charts?

[ahmedwaleedmalik]

The values should decide what to configure and how to configure them including enabling/disabling components. Having extra flags restricts it to the installer which is not so great. It'd be better if users can set this in a single values files instead of extra arguments for installer.

[ahmedwaleedmalik]

I'll just drag(sorry) the author of the issue, Senor @xrstf in the mix to weigh in so that we can just move ahead with this PR. Whatever he says, works for me :D

[marioreggiori]

@ahmedwaleedmalik & @xrstf any updates?

[xrstf]

/approve

sorry this took a while

[kubermatic-bot]

LGTM label has been added.

Git tree hash: a7139d42e7b216ca2c24faa68de2e63aa8d619f3

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioreggiori, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubermatic-installer/OWNERS [xrstf]
• pkg/install/OWNERS [xrstf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[embik]

/retest

[kubermatic-triage-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.