Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VMware Cloud Director CSI driver #12096

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Update VMware Cloud Director CSI driver #12096

merged 4 commits into from
Mar 30, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Mar 27, 2023 •
edited

What this PR does / why we need it:
Update VMware Cloud Director CSI driver to v1.3.2.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Update VMware Cloud Director CSI driver to v1.3.2.

Documentation:

NONE

@ahmedwaleedmalik
Update VMware Cloud Director CSI driver
b7ef667 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Mar 27, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-vmware-cloud-director-ubuntu-1.26

@ahmedwaleedmalik
Fix image tag
de7a35a 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-vmware-cloud-director-ubuntu-1.26

@ahmedwaleedmalik
Refactored code
369501d 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik added kind/chore Updating grunt tasks etc; no production code changes. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Mar 28, 2023
@ahmedwaleedmalik
Copy link
Member Author

/retest 🤷‍♂️

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pre-kubermatic-ccm-migration-aws-e2e
  • /test pre-kubermatic-ccm-migration-azure-e2e
  • /test pre-kubermatic-ccm-migration-openstack-e2e
  • /test pre-kubermatic-ccm-migration-vsphere-e2e
  • /test pre-kubermatic-cilium-e2e
  • /test pre-kubermatic-dualstack-e2e-aws-canal
  • /test pre-kubermatic-dualstack-e2e-aws-cilium
  • /test pre-kubermatic-e2e-anexia-flatcar-1.25
  • /test pre-kubermatic-e2e-aws-ubuntu-1.24
  • /test pre-kubermatic-e2e-aws-ubuntu-1.25
  • /test pre-kubermatic-e2e-aws-ubuntu-1.25-ce
  • /test pre-kubermatic-e2e-aws-ubuntu-1.26
  • /test pre-kubermatic-e2e-azure-ubuntu-1.26
  • /test pre-kubermatic-e2e-do-centos-1.26
  • /test pre-kubermatic-e2e-gcp-offline
  • /test pre-kubermatic-e2e-gcp-ubuntu-1.26
  • /test pre-kubermatic-e2e-hetzner-ubuntu-1.26
  • /test pre-kubermatic-e2e-kubevirt-centos-1.26
  • /test pre-kubermatic-e2e-kubevirt-ubuntu-1.26
  • /test pre-kubermatic-e2e-nutanix-centos-1.26
  • /test pre-kubermatic-e2e-nutanix-ubuntu-1.26
  • /test pre-kubermatic-e2e-openstack-centos-1.26
  • /test pre-kubermatic-e2e-openstack-ubuntu-1.26
  • /test pre-kubermatic-e2e-packet-ubuntu-1.26
  • /test pre-kubermatic-e2e-vmware-cloud-director-ubuntu-1.26
  • /test pre-kubermatic-e2e-vsphere-ubuntu-1.26
  • /test pre-kubermatic-e2e-vsphere-ubuntu-1.26-customfolder
  • /test pre-kubermatic-e2e-vsphere-ubuntu-1.26-datastore-cluster
  • /test pre-kubermatic-etcd-launcher-e2e
  • /test pre-kubermatic-expose-strategy-e2e
  • /test pre-kubermatic-ipam-e2e
  • /test pre-kubermatic-konnectivity-e2e
  • /test pre-kubermatic-kubermatic-validate-prow-yaml
  • /test pre-kubermatic-legacy-machine-controller-user-data-e2e
  • /test pre-kubermatic-lint
  • /test pre-kubermatic-mla-e2e
  • /test pre-kubermatic-nodeport-proxy-e2e
  • /test pre-kubermatic-opa-e2e
  • /test pre-kubermatic-shellcheck
  • /test pre-kubermatic-simulate-github-release
  • /test pre-kubermatic-test
  • /test pre-kubermatic-test-helm-charts
  • /test pre-kubermatic-test-integration
  • /test pre-kubermatic-test-user-ssh-key-agent-multiarch
  • /test pre-kubermatic-verify

The following commands are available to trigger optional jobs:

  • /test pre-kubermatic-dualstack-e2e-alibaba
  • /test pre-kubermatic-dualstack-e2e-azure-canal
  • /test pre-kubermatic-dualstack-e2e-azure-cilium
  • /test pre-kubermatic-dualstack-e2e-canal
  • /test pre-kubermatic-dualstack-e2e-cilium
  • /test pre-kubermatic-dualstack-e2e-digitalocean
  • /test pre-kubermatic-dualstack-e2e-equinix-centos
  • /test pre-kubermatic-dualstack-e2e-equinix-flatcar
  • /test pre-kubermatic-dualstack-e2e-equinix-rockylinux
  • /test pre-kubermatic-dualstack-e2e-equinix-ubuntu
  • /test pre-kubermatic-dualstack-e2e-gcp
  • /test pre-kubermatic-dualstack-e2e-hetzner
  • /test pre-kubermatic-dualstack-e2e-openstack-canal
  • /test pre-kubermatic-dualstack-e2e-openstack-cilium
  • /test pre-kubermatic-dualstack-e2e-vsphere

Use /test all to run the following jobs that were automatically triggered:

  • pre-kubermatic-cilium-e2e
  • pre-kubermatic-dualstack-e2e-aws-canal
  • pre-kubermatic-dualstack-e2e-aws-cilium
  • pre-kubermatic-e2e-aws-ubuntu-1.24
  • pre-kubermatic-e2e-aws-ubuntu-1.25
  • pre-kubermatic-e2e-aws-ubuntu-1.25-ce
  • pre-kubermatic-e2e-aws-ubuntu-1.26
  • pre-kubermatic-kubermatic-validate-prow-yaml
  • pre-kubermatic-verify

In response to this:

/retest 🤷‍♂️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Update csi-controller.yaml
3156b6d 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
xrstf
xrstf approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am super skeptical that this won't explode on upgrades, but I was promised this will be super duper tested.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8329deb215f552efca68259a123fc4c8a50a4b97

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Mar 30, 2023
Closed
@ahmedwaleedmalik
Copy link
Member Author

/retest

@kubermatic-bot kubermatic-bot merged commit cba0c56 into kubermatic:main Mar 30, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf