Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use serializable etcd health endpoint #12190

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Use serializable etcd health endpoint #12190

merged 3 commits into from
Apr 25, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 24, 2023 •
edited by embik

What this PR does / why we need it:
See kubernetes/kubernetes#110744 for more information:

As per the etcd maintainers' recommendation - startup probes shouldn't be serialized, while the liveness probes should be.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Use serializable etcd liveness probes and add a startup probe, as per upstream recommendations.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2023
@xrstf xrstf changed the title WIP - Use serializable etcd health endpoint Use serializable etcd health endpoint Apr 24, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2023
@xrstf xrstf requested a review from embik April 24, 2023 14:59
@embik embik assigned embik and xrstf Apr 24, 2023
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2023
@xrstf xrstf changed the title Use serializable etcd health endpoint WIP - Use serializable etcd health endpoint Apr 24, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2023
@xrstf xrstf changed the title WIP - Use serializable etcd health endpoint Use serializable etcd health endpoint Apr 24, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2023
embik
embik approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 76f7c36ad9251984d9f6ff7fc30643fc56152292

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@embik
Copy link
Member

embik commented Apr 25, 2023

@xrstf I updated the release note to include information about the startup probe, just FYI.

@kubermatic-bot kubermatic-bot merged commit 331fe15 into kubermatic:main Apr 25, 2023
16 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Apr 25, 2023
@xrstf xrstf deleted the etcd-health-endpoints branch April 25, 2023 13:48
@embik
Copy link
Member

embik commented Apr 26, 2023 •
edited

@xrstf what are your feelings on backporting this, since it's categorised as bugfix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@xrstf xrstf

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @kubermatic-bot @embik