Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Minio to RELEASE.2023-05-04T21-44-30Z, change to quay.io #12241

Merged
merged 1 commit into from
May 12, 2023
Merged

update Minio to RELEASE.2023-05-04T21-44-30Z, change to quay.io #12241

merged 1 commit into from
May 12, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 8, 2023 •
edited

What this PR does / why we need it:
This performs a long overdue bumping of Minio. We can also move away from docker.io for this one, as sometime in 2021 Minio changed from docker.io to quay.io: https://github.com/minio/minio/search?q=quay&type=commits

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Update etcd-backup Minio to RELEASE.2023-05-04T21-44-30Z, change to quay.io/minio/minio

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 8, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. labels May 8, 2023
@embik
Copy link
Member

embik commented May 9, 2023

/test pre-kubermatic-etcd-launcher-e2e

Just curious if backups still work.

@xrstf xrstf self-assigned this May 9, 2023
@xrstf xrstf requested a review from embik May 9, 2023 18:23
@embik
Copy link
Member

embik commented May 10, 2023

There's also charts/mla/minio. Do we also want to bump that?

@xrstf
Copy link
Contributor Author

xrstf commented May 10, 2023

I'd treat MLA charts as their own separate thing.

@embik
Copy link
Member

embik commented May 10, 2023

I'd treat MLA charts as their own separate thing.

Can we maybe clarify somehow in the release note which MLA got bumped then?

@xrstf
Copy link
Contributor Author

xrstf commented May 11, 2023

Added a word 😁

embik
embik approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: efe4b5787888c776870dfc8861ddc8e220894e69

@kubermatic-bot kubermatic-bot merged commit 9c2e2de into kubermatic:main May 12, 2023
6 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 12, 2023
@xrstf xrstf deleted the bump-minio branch May 12, 2023 09:02
@embik embik mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@xrstf xrstf

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @kubermatic-bot @embik