Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path traversal in mirror-images command #12293

Merged
merged 1 commit into from
May 16, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 16, 2023

What this PR does / why we need it:
This fixes https://github.com/kubermatic/kubermatic/security/code-scanning/1

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix potential path traversal in mirror-images command

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 16, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2023
@pkprzekwas
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7bfa43663f8be723a3f65d95c625b33bbb964f73

@kubermatic-bot kubermatic-bot merged commit cdbb5d0 into kubermatic:main May 16, 2023
16 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone May 16, 2023
@pkprzekwas
Copy link
Contributor

/cherrypick release/v2.22

@kubermatic-bot
Copy link
Contributor

@pkprzekwas: new pull request created: #12294

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pkprzekwas
Copy link
Contributor

/cherrypick release/v2.21

@kubermatic-bot
Copy link
Contributor

@pkprzekwas: #12293 failed to apply on top of branch "release/v2.21":

Applying: fix path traversal in mirror-images command
Using index info to reconstruct a base tree...
M	pkg/install/images/images.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/install/images/images.go
CONFLICT (content): Merge conflict in pkg/install/images/images.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix path traversal in mirror-images command
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v2.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf deleted the fix-security-1 branch May 16, 2023 12:34
@xmudrii xmudrii added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants