Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-ingress-controller: set memory limits to 1Gi #12411

Merged
merged 1 commit into from
Jun 26, 2023
Merged

nginx-ingress-controller: set memory limits to 1Gi #12411

merged 1 commit into from
Jun 26, 2023

Conversation

wozniakjan
Copy link
Contributor

@wozniakjan wozniakjan commented Jun 23, 2023 •
edited

What this PR does / why we need it:
As discovered during testing: #12340 (comment), the nginx-ingress-controller can become quite memory hungry during the local KKP installation. This PR would like to propose setting the memory limit from the default 512Mi to 1Gi.

Which issue(s) this PR fixes:

n/a

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

nginx-ingress-controller: set default memory limit to 1Gi

Documentation:

NONE

@wozniakjan wozniakjan added kind/bug Categorizes issue or PR as related to a bug. kubermatic-installer labels Jun 23, 2023
@wozniakjan wozniakjan added this to the KKP 2.23 milestone Jun 23, 2023
@wozniakjan wozniakjan requested a review from embik June 23, 2023 10:50
@wozniakjan wozniakjan self-assigned this Jun 23, 2023
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jun 23, 2023
@xmudrii
Copy link
Member

xmudrii commented Jun 23, 2023

@wozniakjan I would consider unconditionally increasing the limit to 1Gi for all setups, not only local. There's only one nginx-ingress per setup, so that shouldn't be a significant bump at all. Looking at the upstream charts, they don't even recommend limits, but I think we should have some more generous limits in place: https://github.com/kubernetes/ingress-nginx/blob/f8bf5a3086fc52114040a60335e2f483e819a14c/charts/ingress-nginx/values.yaml#L319C41-L324

@wozniakjan
Copy link
Contributor Author

I would consider unconditionally increasing the limit to 1Gi for all setups

I'm ok with that, would it be acceptable for you @embik?

@embik
Copy link
Member

embik commented Jun 26, 2023

I would consider unconditionally increasing the limit to 1Gi for all setups

I'm ok with that, would it be acceptable for you @embik?

Sure, fine by me given that nginx-ingress is such a crucial component and if it goes up 400MB for a test setup, it's probably worse in production setups.

@wozniakjan wozniakjan force-pushed the installer_local_bump_nginx_memory_limit branch from 9691d71 to 5d5e4f7 Compare June 26, 2023 06:40
@kubermatic-bot kubermatic-bot added the sig/app-management Denotes a PR or issue as being assigned to SIG App Management. label Jun 26, 2023
@wozniakjan wozniakjan changed the title installer: bump nginx-ingress-controller resource limits for the local cmd nginx-ingress-controller: set memory limits to 1Gi Jun 26, 2023
embik
embik approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 459bd4e84750c0f522d26ac4c0939019b1678640

@wozniakjan
nginx-ingress-controller: bump memory limits
f6bd3a1 
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan force-pushed the installer_local_bump_nginx_memory_limit branch from 5d5e4f7 to f6bd3a1 Compare June 26, 2023 06:46
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@embik
Copy link
Member

embik commented Jun 26, 2023

Please do add a release note since it's changing something user-facing now.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2023
@wozniakjan
Copy link
Contributor Author

Please do add a release note since it's changing something user-facing now.

good point! added as well as adjusted the chart render tests, ptal @embik

@embik embik added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Jun 26, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Jun 26, 2023
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9f83712418893369ca4ccfcc6da2868d2503099

@wurbanski
Copy link
Contributor

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, wozniakjan, wurbanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@kubermatic-bot kubermatic-bot merged commit a3fe6d8 into kubermatic:main Jun 26, 2023
5 checks passed
@embik embik added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@wozniakjan wozniakjan

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wozniakjan @xmudrii @embik @kubermatic-bot @wurbanski