Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.23] Support attaching multiple networks with vSphere VMs #12458

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[release/v2.23] Support attaching multiple networks with vSphere VMs #12458

merged 1 commit into from
Jul 7, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jul 6, 2023 •
edited

What this PR does / why we need it:
Manual backport of #12444

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for configuring multiple networks for vSphere.

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 6, 2023
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review July 6, 2023 14:06
@ahmedwaleedmalik
Copy link
Member Author

/hold this needs kubermatic/machine-controller#1677 to be merged first.

@ahmedwaleedmalik ahmedwaleedmalik changed the title [release/v2.23] Support attaching multiple networks with vSphere VMs WIP: [release/v2.23] Support attaching multiple networks with vSphere VMs Jul 6, 2023
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as draft July 6, 2023 14:54
@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: [release/v2.23] Support attaching multiple networks with vSphere VMs [release/v2.23] Support attaching multiple networks with vSphere VMs Jul 7, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2023
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review July 7, 2023 08:30
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@ahmedwaleedmalik
Copy link
Member Author

cc @kubermatic/sig-release-managers

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Jul 7, 2023
@embik
Copy link
Member

embik commented Jul 7, 2023

Seems there is something failing with the new machine-controller image:

etcd_test.go:163: failed to setup test environment: failed to create cluster: failed to wait for cluster to become healthy: timed out waiting for the condition; last error was: cluster is unhealthy: [machineController=provisioning]

xmudrii
xmudrii requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but other than that, I think we can merge this.

pkg/validation/cluster.go Outdated Show resolved Hide resolved
pkg/apis/kubermatic/v1/cluster.go Show resolved Hide resolved
pkg/crd/k8c.io/kubermatic.k8c.io_clusters.yaml Show resolved Hide resolved
pkg/machine/provider/vsphere.go Outdated Show resolved Hide resolved
@ahmedwaleedmalik
Copy link
Member Author

Seems there is something failing with the new machine-controller image:

etcd_test.go:163: failed to setup test environment: failed to create cluster: failed to wait for cluster to become healthy: timed out waiting for the condition; last error was: cluster is unhealthy: [machineController=provisioning]

TIL: we don't generate images against commits for the release branches in machine-controller.

@ahmedwaleedmalik
Support attaching multiple networks with vSphere VMs
4cc852c 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

I've updated the PR @xmudrii, PTAL.

We'll have to cut a new release for machine-controller i.e. v1.57.1 for updating the image. I think it's too early to cut that release though since we are still ~20 days behind the release date. I'd recommend that we do that later in a separate PR.

xmudrii
xmudrii approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6eaa53a71d23f6814507c4f6f400a33e3c9a4963

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 4aa4aa1 into kubermatic:release/v2.23 Jul 7, 2023
20 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Jul 7, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the release-v2.23/vsphere-networks branch July 7, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@embik embik Awaiting requested review from embik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmedwaleedmalik @embik @kubermatic-bot @xmudrii