Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for configuring IPFamilies and IPFamilyPolicy for nodeport-proxy #12472

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Support for configuring IPFamilies and IPFamilyPolicy for nodeport-proxy #12472

merged 1 commit into from
Jul 12, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jul 12, 2023 •
edited

What this PR does / why we need it:
This PR adds support for configuring IPfamilies and IPFamilyPolicy for nodeport-proxy. This is essential for cases where we need either both IPv4 and IPv6 addresses, just IPv6 IP, IPv6 IP for the LoadBalancer, etc.

Which issue(s) this PR fixes:

Fixes #12471

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for configuring IPFamilies and IPFamilyPolicy for nodeport-proxy

Documentation:

NONE

@ahmedwaleedmalik
Support for configuring IPFamilies and IPFamilyPolicy for nodeport-proxy
0c3a149 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 12, 2023
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2023
ahmedwaleedmalik
ahmedwaleedmalik commented Jul 12, 2023
View reviewed changes
docs/zz_generated.seed.ce.yaml
@@ -574,6 +574,10 @@ spec:
requests:
cpu: 50m
memory: 32Mi
# IPFamilies configures the IP families to use for the LoadBalancer service.
ipFamilies: null
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should leave this as is for demonstration purposes or redact this field from the example. WDYT @xrstf? I would like to avoid defaulting it to let's say IPv4 or something since it's mostly determined by the configuration that you used to create the underlying kubernetes cluster.

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Jul 12, 2023
@xrstf
Copy link
Contributor

xrstf commented Jul 12, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5174793f53e6ea044d21f00d81489176bcd316ed

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member Author

/retest
flake

@kubermatic-bot kubermatic-bot merged commit 2b0d0fd into kubermatic:main Jul 12, 2023
20 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Jul 12, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the ip-fam branch July 12, 2023 12:43
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.23

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 18, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #12480

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Support for configuring IPFamilies and IPFamilyPolicy for nodeport-proxy
3 participants
@ahmedwaleedmalik @xrstf @kubermatic-bot