Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable csi driver installation on user clusters #12515

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

akash-gautam
Copy link
Contributor

@akash-gautam akash-gautam commented Jul 28, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:
Partially fixes #12008

What type of PR is this?

Special notes for your reviewer:
This PR provides the option for disabling CSI driver installation at the data centre and cluster levels. Another PR will follow that will take care of uninstalling the CSI drivers on existing user clusters if the admin/users disabled it at the dc/cluster level.

Does this PR introduce a user-facing change? Then add your Release Note here:

Add support for disabling CSI drivers for user clusters. This can be configured at a user cluster and datacenter level. If the admin disables CSI drivers at a datacenter level then the user is prohibited from enabling them at the user cluster level.

Documentation:

TBD

@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2023
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. and removed docs/provided Denotes a PR that has a valid documentation reference. labels Jul 31, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title option to disable csi driver installation on user clusters Option to disable csi driver installation on user clusters Aug 1, 2023
@xrstf
Copy link
Contributor

xrstf commented Aug 9, 2023

/approve

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3a28aced99800d2b1bf106178e848355798b04f6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, akash-gautam, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member

Thanks, for the excellent work @akash-gautam 🎉

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 4d87107 into kubermatic:main Aug 9, 2023
20 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable CSI drivers
5 participants