-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer: local command reference KubeVirt images from quay #12534
installer: local command reference KubeVirt images from quay #12534
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
702f250
to
d5218b1
Compare
"github.com/google/uuid" | ||
"github.com/jackpal/gateway" | ||
"github.com/sirupsen/logrus" | ||
"github.com/spf13/cobra" | ||
"gopkg.in/yaml.v3" | ||
"gopkg.in/yaml.v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the local command at the moment depends on yaml.v2
API, bumping to v3
causes
value cannot be set because dex is not a map[any]any: map[string]interface {} ...
d5218b1
to
1be93c0
Compare
1be93c0
to
f0cddc0
Compare
/test pre-kubermatic-trivy-scan |
thanks @xrstf, really good points! |
/approve |
LGTM label has been added. Git tree hash: e008e9b24762caa2bb21eb668d4ddda82d578331
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wozniakjan, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release/v2.23 |
@wozniakjan: #12534 failed to apply on top of branch "release/v2.23":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Currently, the
kubermatic-installer local kind
pulls the VM images from HTTP source. This will switch the preconfigured default to pull from OCI registry https://quay.io/organization/kubermatic-virt-disksWhich issue(s) this PR fixes:
Fixes #12341
What type of PR is this?
/kind cleanup
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: