Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reconcile loop for seed-proxy on Kubernetes 1.27 #12557

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix reconcile loop for seed-proxy on Kubernetes 1.27 #12557

merged 2 commits into from
Aug 15, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 15, 2023 •
edited

What this PR does / why we need it:
This fixes a reconcile loop in KKP:

2023-08-15T13-33-24

With this patch, KKP will not overwrite unrelated labels on seed-proxy resources anymore.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix reconcile loop for `seed-proxy-token` Secret on Kubernetes 1.27

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
@xrstf xrstf changed the title fix reconcile loop for seed-proxy on Kubernetes 1.27 WIP _ Fix reconcile loop for seed-proxy on Kubernetes 1.27 Aug 15, 2023
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@embik
Copy link
Member

embik commented Aug 15, 2023

Fix reconcile loop for seed-proxy on Kubernetes 1.27

Minor nit: I think we should specify the release note a bit, maybe:

Fix reconcile loop for seed-proxy-token Secret on Kubernetes 1.27

@xrstf xrstf changed the title WIP _ Fix reconcile loop for seed-proxy on Kubernetes 1.27 Fix reconcile loop for seed-proxy on Kubernetes 1.27 Aug 15, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Aug 15, 2023
Merged
embik
embik approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef0c67171e397c1d844163c38b3ece51cc8b6a8b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf
Copy link
Contributor Author

xrstf commented Aug 15, 2023

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit fdb5dc2 into kubermatic:main Aug 15, 2023
20 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Aug 15, 2023
xrstf added a commit to xrstf/kubermatic that referenced this pull request Aug 16, 2023
@xrstf
[release/v2.23] Fix reconcile loop for seed-proxy on Kubernetes 1.27 (k…
d13de30 
…ubermatic#12557)
@xrstf xrstf mentioned this pull request Aug 16, 2023
Merged
xrstf added a commit to xrstf/kubermatic that referenced this pull request Aug 16, 2023
@xrstf
[release/v2.22] Fix reconcile loop for seed-proxy on Kubernetes 1.27 (k…
f536e05 
…ubermatic#12557)
@xrstf xrstf mentioned this pull request Aug 16, 2023
Merged
kubermatic-bot pushed a commit that referenced this pull request Aug 16, 2023
@xrstf
[release/v2.23] Fix reconcile loop for seed-proxy on Kubernetes 1.27 (#…
631ccce 
…12557) (#12566)
kubermatic-bot pushed a commit that referenced this pull request Aug 16, 2023
@xrstf
[release/v2.22] Fix reconcile loop for seed-proxy on Kubernetes 1.27 (#…
bf384fd 
…12557) (#12567)
@pkprzekwas pkprzekwas added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label Aug 21, 2023
@xrstf xrstf deleted the fix-reconcile-loop branch August 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xrstf @embik @kubermatic-bot @kubermatic-triage-bot @pkprzekwas