Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for configuring dex theme via values.yaml #12560

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Support for configuring dex theme via values.yaml #12560

merged 1 commit into from
Aug 15, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Aug 15, 2023 •
edited

What this PR does / why we need it:
An important requirement from our customers is to add their own branding for our dashboard and dex. For updating the theme of dex, users can update the files in theme directory which are then propagated and installed in the form of a kubernetes secret.

While this works it also adds a huge limitation since all the files need to exist and be up-to-date in the theme directory before running the installer. This PR adds a way to consume those assets from values.yaml as well. With this change, we don't need to maintain those files anymore, all the user needs is to maintain a single values file.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for configuring the dex theme via values file.

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Aug 15, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2023
ahmedwaleedmalik
ahmedwaleedmalik commented Aug 15, 2023
View reviewed changes
charts/oauth/values.yaml
# Theme contains the Dex theme assets converted to string and base64 encoded.
# By default, the assets from `/theme` directory are used.
theme: {}
# favicon.png: iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAIGNIUk0AAHomAACAhAAA+gAAAIDoAAB1MAAA6mAAADqYAAAXcJy6UTwAAAAGYktHRAD/AP8A/6C9p5MAAAYrSURBVFjDvZdriF1XFcd/e9/nTGbijAEbEnUmbdGGIE4QaYKFTpvaQgWTSijiKxPUVJTSVMEgCBo0UCix1keqIGYqVJsiNm2DxBY7sbU1iHGmoUK1CpOaTJKZzNx7zzn3PPZr+eFOhpLEJjdF14fzaa/1/+3/WqxzjqKLuPO51oDSPKSUGiuFcOSp2wZu6Sb/UlHu5rDPGHMlxkriqVv7drUB0N0c/ud8PnB2PiOeT3BzEQBz9VUj/xeAmcGhkd0Pf2XbzMwc86fOsOKl50dP11YLMDlXXyVz9VWTZ6urdv5PAE4PDu3UQSZv+8fR4a2Hf8HcG6donlu4MHkExUPT5ZWTf+991xW78pYzMDM4NKBgvwqyRbsAQfjWn35F1E6ZrS9HK7V4UjpPDZTUCIqJv/WtXL8uOTN91Q7MDA4NK2FCu7BF24DygogG0Txw/Gmuq0NJwxLDYigUSqkBD/uvugUzg0MDOsiEdmFEu4AKQggaLwovChHFBrfAczd9nCByAcAiBIwe7Vu95apasHjz4c6tO4JeFE4UFlj2ua1cv+2LfPXEAP++dh2fHd+DWmoECBoQPLIZONiVA2dWDH+75PwIDrzXeK+xQS+Jy9BqrvnZXsrvXU0StTl0x2f44Td+QrxsOQIEICB4FB410nULtMg2sR1xFzQ2KKyAETAI/du2nr8mUlhMZpm88XZ+8MDjnFyzFhGPJVDg8YTuAYBhHzTWK2wAAxgRcgT1wbWsuPfznVMhIFkO7QyfW2auX8e+B5/g1Q234yVg8AT85fQvBhANTsABDsGKULl5A0O/P8D7/3KY0sDyJQCV55Bl+CTFZoa87x08/p1xXvz01xBAEZpdD6ELTFsYdkpwQP3mG1nz/IGLM0OAIkflKZgebGZQJU1PT4Vj275OY+V72Pi9+6a6dsAUbLcajBIMQs/oxktniiCZQbKCkOa4wpIXjiz3eCu8dsvd/Gj/q6Mf/W001hXAmvaJI1ax3agOxNwLL19aPwjBGHyaEzKLzxw2dySZJWpbktig+t9JvVzZv+mZhZErBgD4QPHGuEG2pypw6o8vc2zHzks64I3DFRaXFbgkx8UZWZQx20xYSHIqlRK95Sr1cmXi1qdnh68YAGCjOzmeadmeaeG1Xx7g1x/ZxOF9j7xJX7DGYnJLnqbkSYKJ2rhmQtZo47ynaSytEFCV2kBZl5/sCgDgTnN6vNBhfaJC89njx3h01y7+8NhjSy2whSXPDXk7IY0i4oUWyUKLqBWjVaBdFETW0hDB6crIpt+cHesKAOBT7bNTz+565GCjtw8nwqEf71t0IGCKgiRLacUJSSsib7SIGk2cyyniBNtKsGmGMQUZoIK+78L6l/0k+9jh5nDLqbHyl/bSs/cLvP7KK4sOBNKiwCKUvKHPGHoqVeJKhRXLq5gooeI8Je9QpgrVCuLkomG8rAOCjIkI8qFbMTdtxgNHnzmEiGCsIc0zkjRF0jZFGmODI43amCghRAm0EnScUYozcBdvxst/EaWWqg3UcotsugcnwoM7dnD8hRc76zgEsA4pCuadJy8MeTvFxm1C3IY4RUcpKsnBuu4BWlE6HeYjQqONL/VjrrmWqNXk0T17QKSzEZ0jco7ceUKe47IMl6bYdoZvZ4R2jhQW7/x01wAvjQ2PTy+ca87OztM4t0Dj3etxIgQJHXHvEefInEeMgaLA5zmmMGR5QZJb4tzStg5j3ZGuhxCgGSd3pXE2UU/bSP8wfXTe+4h0AEIACZ31HAJeKbJSCafLlEoWVXH0E1De7e5+BoDZ744eacbx9kac0KitxpZreASCB+/f1AqL8hbnLbnzJM7TdJ5EBTJn7//rvTd034Lzkfz87vE4aq3P0nRqfvAGROiIBllqBcETQsCLYEQoAFsGXQ7jJ7/54e9fqm7pSgEA/OuHz7h//e6n2XWfOFEt4pFW//sGCL5jvwK0hnIFqjXo7YFlNajp3cXeO+7/bzW7Ajgf7syfp1prvzyIhFElHg2okkYqZajXYVkvLKtNUy3fxb7N429Vq6uf0wtDi1AClFZIuQK9PYTe2hRV/TD7Pzl+JTXeFkBNQR3VDJXKlKnXnpJK5WB48p7pbmr8B3ATxATU5NDqAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIzLTAyLTIzVDE0OjIxOjEyKzAwOjAwDYmh3gAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMy0wMi0yM1QxNDoyMToxMiswMDowMHzUGWIAAAAodEVYdGRhdGU6dGltZXN0YW1wADIwMjMtMDItMjNUMTQ6MjE6MTIrMDA6MDArwTi9AAAAAElFTkSuQmCC
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to keep it here as an example for the users.

@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.23

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xrstf
xrstf approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 440cc80dddb27356f5221dcd1de3e8b0c223bbe7

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
@ahmedwaleedmalik
Support for configuring dex theme via values.yaml
a8bd4fc 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2023
@xrstf
Copy link
Contributor

xrstf commented Aug 15, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1faf1ea9de3c94dec2f79a8d1ea4f41d0ad023b9

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 005285c into kubermatic:main Aug 15, 2023
5 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the update-oauth-chart branch August 15, 2023 17:34
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Aug 15, 2023
@kubermatic-bot kubermatic-bot mentioned this pull request Aug 15, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #12562

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. customer-request dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf