Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Kubernetes 1.24 #12570

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Remove support for Kubernetes 1.24 #12570

merged 5 commits into from
Aug 21, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 17, 2023 •
edited

What this PR does / why we need it:
Kubernetes 1.24 has gone End-of-Life on July 28th, 2023. In accordance with our support policy, this PR removes support for creating new 1.24 userclusters, but keeps basic support for reconciling existing 1.24 userclusters.

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove support for creating new Kubernetes 1.24 clusters (existing clusters can still be reconciled, but should be upgraded sooner than later).

Documentation:

https://github.com/kubermatic/docs/pull/1508

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member

/lgtm cancel

Need to fix the tests

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@embik embik mentioned this pull request Aug 17, 2023
Closed
@embik
Copy link
Member

embik commented Aug 18, 2023

@xrstf the docs section on this PR says "NONE", but it will require updating our Kubernetes support matrix. Can you please make sure to change it to "TBD" at least?

@xrstf xrstf mentioned this pull request Aug 21, 2023
Merged
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/none Denotes a PR that doesn't need documentation (changes). labels Aug 21, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 🚀

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ccac14d6734944dc9c8336added1bbc6fb03b7f5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 95cb1d8 into kubermatic:main Aug 21, 2023
26 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Aug 21, 2023
@xrstf xrstf mentioned this pull request Aug 22, 2023
Merged
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Aug 23, 2023
Closed
@xrstf xrstf deleted the remove-1.24 branch August 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xrstf @kubermatic-triage-bot @ahmedwaleedmalik @embik @kubermatic-bot