Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vSphere: support for propagating cluster tags to folders #12581

Merged
merged 1 commit into from
Aug 22, 2023
Merged

vSphere: support for propagating cluster tags to folders #12581

merged 1 commit into from
Aug 22, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Aug 21, 2023 •
edited

What this PR does / why we need it:
For vSphere, this PR adds support for propagating the tags specified at the user cluster level to the folders managed by KKP.

Currently, admins can specify tags against a pre-existing tag category at the cluster level. These tags are then managed by KKP. With the changes from this PR, these tags will now be propagated to the folders managed by KKP as well. Please note that these tags will NOT be attached to pre-existing folders that were created outside of KKP.

Which issue(s) this PR fixes:

Fixes #12554

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

vSphere: support for propagating cluster tags to folders created by KKP

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Aug 21, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2023
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Copy link
Member Author

/hold I need to test a few things

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title vSphere: support for propagating cluster tags to folders [WIP] vSphere: support for propagating cluster tags to folders Aug 21, 2023
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title [WIP] vSphere: support for propagating cluster tags to folders vSphere: support for propagating cluster tags to folders Aug 21, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
@ahmedwaleedmalik
Copy link
Member Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@ahmedwaleedmalik
Support for propagating cluster tags to folders
e11b14d 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

{"level":"info","time":"2023-08-21T16:25:43.591Z","caller":"runner/events.go:65","msg":"ERROR","scenario":"vsphere-ubuntu-containerd-1.27.3","cluster":"kkp-1693649463408594944-vm4jv","EventType":"Warning","Number":5,"Reason":"ReconcilingError","Message":"failed to reconcile Addon "default-storage-class": failed to deploy the addon manifests into the cluster: failed to execute '/usr/local/bin/kubectl-1.27 --kubeconfig /tmp/cluster-kkp-1693649463408594944-vm4jv-addon-default-storage-class-kubeconfig apply --prune --filename /tmp/cluster-kkp-1693649463408594944-vm4jv-default-storage-class.yaml --selector kubermatic-addon=default-storage-class' for addon default-storage-class of cluster kkp-1693649463408594944-vm4jv: exit status 1\nstorageclass.storage.k8s.io/vsphere-csi unchanged\nError from server (InternalError): error when creating "/tmp/cluster-kkp-1693649463408594944-vm4jv-default-storage-class.yaml": Internal error occurred: failed calling webhook "validation-webhook.snapshot.storage.k8s.io": failed to call webhook: Post "https://snapshot-validation-service.kube-system.svc:443/volumesnapshot?timeout=2s\": dial tcp 10.240.27.136:443: connect: connection refused\n","Source":"kkp-addon-controller"}
{"level":"info","time":"2023-08-21T16:25:43.609Z","caller":"clients/client_kube.go:346","msg":"Deleting user cluster now...","scenario":"vsphere-ubuntu-containerd-1.27.3","cluster":"kkp-1693649463408594944-vm4jv","client":"kube"}

For pre-kubermatic-e2e-vsphere-ubuntu-1.27-customfolder and pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster, looks unrelated to this PR. Will check tomorrow.

@ahmedwaleedmalik
Copy link
Member Author

The test failures are not related to this PR. I have created this issue to track them #12587, someone needs to pick the ticket and fix them.

@xrstf we need to override pre-kubermatic-e2e-vsphere-ubuntu-1.27-customfolder and pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster for this PR.

xrstf
xrstf approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/shipit
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7bde42c9ab7f7fbe6709207b16ce3ffac9d1d09b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf
Copy link
Contributor

xrstf commented Aug 22, 2023

/override pre-kubermatic-e2e-vsphere-ubuntu-1.27-customfolder
/override pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pre-kubermatic-e2e-vsphere-ubuntu-1.27-customfolder, pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster

In response to this:

/override pre-kubermatic-e2e-vsphere-ubuntu-1.27-customfolder
/override pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor

xrstf commented Aug 22, 2023

/override pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster

In response to this:

/override pre-kubermatic-e2e-vsphere-ubuntu-1.27-datastore-cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 764e1b8 into kubermatic:main Aug 22, 2023
21 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Aug 22, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the vsphere-folder-tags branch August 22, 2023 09:17
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.23

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #12591

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Aug 22, 2023
Closed
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

Configure tags to be set on vSphere folder created by KKP
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf