Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Digitalocean CCM version depend on the cluster version #12600

Merged
merged 3 commits into from
Sep 5, 2023
Merged

make Digitalocean CCM version depend on the cluster version #12600

merged 3 commits into from
Sep 5, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 24, 2023 •
edited

What this PR does / why we need it:
Digitalocean has a "follow us" compatibility policy and while DO and KKP usually support the same range of Kubernetes versions, I felt that it was still a bit wobbly and would rather use the same mechanism we use for all other CCMs: Make the CCM version depend on the cluster version.

This PR therefore changes the const into a function and leaves some comments behind.

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Digitalocean CCM versions now depend on the user cluster version, following the loose [upstream compatibility guarantees](https://github.com/digitalocean/digitalocean-cloud-controller-manager#releases).

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2023
@xrstf
Copy link
Contributor Author

xrstf commented Aug 24, 2023

/test pre-kubermatic-e2e-do-centos-1.27

@xrstf
Copy link
Contributor Author

xrstf commented Aug 24, 2023

/retest

1 similar comment
@xrstf
Copy link
Contributor Author

xrstf commented Aug 24, 2023

/retest

@xrstf
Copy link
Contributor Author

xrstf commented Aug 28, 2023

/hold

There is uncertainty if we really want this.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2023
@xrstf xrstf self-assigned this Aug 28, 2023
@xrstf
Copy link
Contributor Author

xrstf commented Aug 31, 2023

/approve cancel

@kubermatic-bot kubermatic-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 4, 2023
@xrstf
Copy link
Contributor Author

xrstf commented Sep 4, 2023

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
xmudrii
xmudrii approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dcfaf4852b7995618fc98f0f3ec25842984ae981

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@xmudrii
Copy link
Member

xmudrii commented Sep 4, 2023

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

5 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@xrstf
Copy link
Contributor Author

xrstf commented Sep 5, 2023

/retest

@kubermatic-bot kubermatic-bot merged commit 1af5e2a into kubermatic:main Sep 5, 2023
20 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Sep 5, 2023
@xrstf xrstf deleted the dynamic-do-ccm branch September 5, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xrstf xrstf

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrstf @kubermatic-bot @xmudrii @kubermatic-triage-bot