Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.23] Update to Go 1.20.8 #12642

Merged
merged 2 commits into from
Sep 15, 2023
Merged

[release/v2.23] Update to Go 1.20.8 #12642

merged 2 commits into from
Sep 15, 2023

Conversation

embik
Copy link
Member

@embik embik commented Sep 14, 2023

What this PR does / why we need it:
This bumps the build image to a version with Go 1.20.8. It's a spiritual cherry-pick of #12636.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind cleanup
/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Update to Go 1.20.8

Documentation:

NONE

@embik
[release/v2.23] Bump prow jobs to build image with Go 1.20.8
e35785c 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
[release/v2.23] Bump scripts to build image with Go 1.20.8
5471493 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik self-assigned this Sep 14, 2023
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 14, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Sep 14, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/chore Updating grunt tasks etc; no production code changes. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2023
@embik embik requested a review from xrstf September 14, 2023 12:44
@xrstf
Copy link
Contributor

xrstf commented Sep 14, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d2ae5be9f1ccb0b49ba79cb8d1f2d2256d0be4e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@embik embik added the cherry-pick-approved Indicates a PR has been approved by release managers. label Sep 14, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 14, 2023
@embik
Copy link
Member Author

embik commented Sep 14, 2023

/retest

1 similar comment
@embik
Copy link
Member Author

embik commented Sep 14, 2023

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

8 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@embik
Copy link
Member Author

embik commented Sep 15, 2023

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2023
@embik
Copy link
Member Author

embik commented Sep 15, 2023 •
edited

@xrstf can you please override the failing ccm test? The network in OpenStack cannot be deleted because there is a VM in that network that is stuck in deletion. I don't believe the CCM migration is affected by this PR.

@xrstf
Copy link
Contributor

xrstf commented Sep 15, 2023

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2023
@kubermatic-bot kubermatic-bot merged commit 1aafdac into kubermatic:release/v2.23 Sep 15, 2023
25 checks passed
@embik embik deleted the go-update-v2.23 branch September 15, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@embik @xrstf @kubermatic-bot @kubermatic-triage-bot